fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.37k stars 421 forks source link

Cant get rid of "CANCEL_PRINT macro not found in configuration warning" #381

Closed sgall17a closed 2 years ago

sgall17a commented 3 years ago

Affected Version(s):

fluidd. v1.16.2 UP TO DATE klipper v0.9.1-667-g31761500 UP TO DATE moonraker. v0.7.1-34-g5522e15

Raspberry Pi Zero W Rev 1.1

ARMv6-compatible processor rev 7 (v6l) 358.0 MB. BCM2835 32bit armv6l with 1 cores Raspbian GNU/Linux 10 (buster) buster. debian. v0.9.1-667-g31761500

(The versions of fluidd this issue occurs on.)

Platform:

Macbook ->Chrome ->

Hardware Configuration:

Pi Zero-> Mks mini e3-> ender3 pro

Reproduction Steps:

Installed fluidd.zip package on raspberry pizero and updated from web interface.

  1. Connected pi zero and ender3 with klipper firmware from package above.
  2. Everything seems to work well (x,y,z movements, bed and extruder heater ok)
  3. Add rows in fluidd.config as per https://docs.fluidd.xyz/configuration/initial_setup

Actual Results:

Keep getting "CANCEL_PRINT macro not found in configuration. even though it is there as per documents." The other warnings from before adding the extra rows have gone away.

Expected Results:

When I define CANCEL_PRINT macro the warning should go away.

Will my prints mysteriously fail because of this warning?:

m-sundman commented 3 years ago

Based on some comments I found by googling the problem seems to be related to this in fluidd.cfg:

[gcode_macro CANCEL_PRINT]
...
rename_existing: CANCEL_PRINT_BASE
...

Can't add another CANCEL_PRINT macro, presumable because it exists in fluiff.cfg, but it still shows that warning about CANCEL_PRINT missing. I wouldn't be surprised if this was the cause of the position confusion in issue #385 tho.

RolledR commented 3 years ago

I'm having the same issue on FluiddPi, except mine complains about [virtual_sdcard],[pause_resume],[display_status], AND CANCEL_PRINT, despite copying everything from Initial Setup to fluidd.cfg.

I tried deleting fluidd.cfg as well as restarting both the printer and the pi. Pi and Fluidd fully updated. fluidd: v1.16.2 klipper: v0.9.1-679-g7fddc5a8 moonraker: v0.7.1-35-g5204fe3

My fluidd.cfg (.txt so I could upload it.)

Can I simply ignore the error, or will it cause issues?

sgall17a commented 3 years ago

Hi, I fixed my problem by putting the cancel_print and other macros in printer.cfg. I think it was my silly mistake and possibly slightly unclear documentation.

RolledR commented 3 years ago

Thanks, that fixed it for me as well. Not quite sure what's going on then, as I was following this tutorial, and it seemed like everyone else did it as I did without running into any issues.

I would appreciate some clarification about whether the tutorial is wrong or this is a bug. Or if I just can't follow instructions and missed something.

justheath commented 2 years ago

Does your printer.cfg import your fluidd.cfg? If not, add this: [include fluidd.cfg]?