search

fluidex / circuits

GNU Affero General Public License v3.0
10 stars 5 forks source link

feature: implement strategy of overwrite order tree in circuit #105

Open 0xmountaintop opened 3 years ago

0xmountaintop commented 3 years ago

closed via https://github.com/Fluidex/circuits/pull/110

0xmountaintop commented 3 years ago

In previous version we check signature for PlaceOrder.

Now we don't have PlaceOrder anymore and we don't check signature for SpotTrade?

In my opinion we should still verify "place_order" tx signature in SpotTrade.

lispc commented 3 years ago

Sigs are verified. https://github.com/Fluidex/circuits/blob/57c7fdcb373c3f7b9e286ed452400a007f7aa2e9/src/spot_trade.circom#L317

lispc commented 3 years ago

https://github.com/Fluidex/circuits/blob/57c7fdcb373c3f7b9e286ed452400a007f7aa2e9/src/block.circom#L141

0xmountaintop commented 3 years ago

I see.