search

fluidex / rollup-state-manager

5 stars 6 forks source link

Integrate with feature `non-blocking-tracing` of `common-rs` #144

Closed silathdiir closed 3 years ago

silathdiir commented 3 years ago

Closes https://github.com/Fluidex/rollup-state-manager/issues/112

TODO: Will also update for dingir-exchange and prover-cluster.

HAOYUatHZ commented 3 years ago

should we use RUST_LOG=rollup_state_manager=debug,info (so info by default)? Would like to hear about your thoughts.

silathdiir commented 3 years ago

should we use RUST_LOG=rollup_state_manager=debug,info (so info by default)? Would like to hear about your thoughts.

@HAOYUatHZ I added RUST_LOG=error for the code https://github.com/Fluidex/common-rs/blob/master/src/non_blocking_tracing.rs#L43, which I wanted to async-log the panic with log level Error.

🤔 I think holding the sequence of logs (for same thread) may be better than println! directly. Should I fix to invoke log::info! or println! directly for the panic message? WDYT?