search

flukejones / asusctl

Daemon and tools to control your ASUS ROG laptop. Supersedes rog-core.
https://asus-linux.org/
Mozilla Public License 2.0
138 stars 19 forks source link

Add support for 2024 G14 (GA403UI) #23

Closed jschoubben closed 3 months ago

jschoubben commented 4 months ago

The 2024 G14 has the Anime Matrix Display replaced with a Slash Led Display. This pull-requests includes support for this new device.

Done [x] [asusd] Add ZBus org.asuslinux.Slash [x] [asusctl] Add enable functionality [x] [asusctl] Support brightness changes [x] [asusctl] Support "interval" setting [x] [asusctl] Supoort changing the Animation (SlashMode)

Todo [ ] [asusd] Add support to run a specific animation once on "events" [ ] [rog-control-center] Add a new screen to configure the Slash

ps. I wasn't able to commit/push without the --no-verify flag enabled. the cargo test --all command fails on 2 tests regarding the Aura device so I'm not sure how you would like me to approach this.

Looking forward to any feedback!

resolves #21

flukejones commented 3 months ago

Lucky I checked github. It doesn't email me about PR or issues.

Are you able to add a simulator for this please? The existing Anime one should be a good starting point.

jschoubben commented 3 months ago

I'll get to it as soon as I can.

I wasn't sure about your views/opinions regarding PR's (it's clear now), I'll try to make it as pristine as possible. I use RustRover which makes a lot of "suggestions" to optimize/clean/improve your codebase.

Also, after merging main, rog-control-center started crashing due to the newly add tray functionality.

Thanks for the review!

flukejones commented 3 months ago

It's not a super major, but if you rebase it should help a little - and don't worry too much about the extraneous changes.

Yeah... That tray has become a problem - I'll have to either revert back to the old one or make changes upstream.

flukejones commented 3 months ago

Just a note on the G16, we can assume it uses the same MCU ID as the G14, this was true of the last 3 years of AniMe matrix. And we can make the slash length the same as the G14 for now until someone with the device amends it.

If you wanted to add effect handling, using the Doom light animations is probably a good test (from RGB keyboard stuff).

But if you add a simulator it will be a piece of cake.

flukejones commented 3 months ago

Hey mate I might merge this now so I can prevent more conflicts.

jschoubben commented 3 months ago

I'm sorry, we're having a tight deadline at work and I didn't find the time yet to resolve your comments. It's still on my todo-list, I'll get back to it as soon as I can.

Sorry for the delay!