Please add support for ROG Strix G731GV

[TabPaD]

Well honestly when I decided to install linux on my machine I was really prepared to give up all the extra functions which was offered with asus drivers on Windows. But then, when I found this project incidently, I was so amazed that I can't even begin to describe... My Asus ROG G731GV wasn't on the list but I decided to give it a try and the results are quite satisfying. In fact almost everything other than Fan Modes and LED Modes work fine. Changing Fan modes or LED color either using physical keys or bash commands is not possible and right now I'm stuck with static red color on the keyboard (before installing rog-core it was turned off). Media and FN+ keys including Mic mute, volume control, screen brightness, touchpad toggle, sleep, airplane mode and even Charge Limit all work fine.

• Distro: Linux Mint 20 Ulyana

• Kernel: 5.4.0-42-generic

• cat /sys/class/dmi/id/product_name: ROG Strix G731GV_G731GV

• cat /sys/class/dmi/id/product_family: ROG Strix

• cat /sys/class/dmi/id/board_name: G731GV

• lsusb | grep 0b05: Bus 001 Device 003: ID 0b05:1866 ASUSTek Computer, Inc. N-KEY Device laptop_info.LOG

• sudo journalctl -b --unit rog-core > rog-core.log rog-core.log

• `sudo usbhid-dump > usbhid.log usbhid.log

here are some pictures of the keyboard:

[flukejones]

Are you able to list which LED modes should work for your machine? If you still have windows installed you can cycle through them. Otherwise I'll add your laptop to a default minimal list.

DOes it support RGB per key?

[flukejones]

Hmm, per-key, 4-zone, and others? Looks very similar to another laptop recently added, I'll follow that one (G531GW)

[TabPaD]

It has 4 zones. Here is a picture of aura creator app which shows all the lights on the keyboard and sides of laptop.

Using keyboard shortcuts I can cycle through Static, Breathing, Strobing, Color Cycle and Rainbow. And yes it should be very similar to G531 Series. Mine has 17" display screen compared to G531's 15" screen.

[flukejones]

If you're comfortable with building the app on your own, the latest master should have the support you need.

[TabPaD]

I would love to help but unfortunately I'm not very familiar with Rust.

[flukejones]

Which distro mate?

[TabPaD]

If you mean which distro I’m using, I’ve mentioned it in my first post. Linux Mint 20 Ulyana

[TabPaD]

Just a little reminder!! G731 or at least G731GV has 4-zone RGB and is added in the wrong section.

[flukejones]

tech specs for reference.

[TabPaD]

Okay it seems that there are different Versions of G731. i.e. Strix Hero III G731, Strix Scar III G731 and Strix G731. These are the correct technical specs for my laptop!

One Zone RGB lighting (GT/GU) 4 Zone RGB lighting (GV/GW)

This is also shown in the screen shot from Aura Creator app on Windows!

[flukejones]

Thanks for the detail. I will add these variants at a later date. If you want to do this now it's not a hard task - add a block like this:

    } else if board_name.starts_with("G731GV")
        || board_name.starts_with("G731GW")
    {
        laptop.supported_modes = vec![ SINGLE, BREATHING, STROBE, RAINBOW,  MULTISTATIC, ];
    } else if board_name.starts_with("G731GT")
        || board_name.starts_with("G731GU")
    {
        laptop.supported_modes = vec![ SINGLE, BREATHING, STROBE, RAINBOW,  RGB, ];

above this line.

Add whichever modes are required. Do note that RGB here means "per-key RGB". Sorry, it's a bit badly named as this once targeted only one laptop.