add support for mqtt v5

flukso / lua-mosquitto

Lua bindings to the libmosquitto MQTT client library.

https://github.com/flukso/lua-mosquitto

Other

63 stars 42 forks source link

add support for mqtt v5 #33

Open niecore opened 2 years ago

niecore commented 2 years ago

Fixes #26

I decided to to create separate functions for all v5 functionality because of the following reason:

This lib is a wrapper for libmosquitto and they did the same way
Some functions have additional functionality besides the props like reason codes or bind addresses

While this PR is open I will check further how testing could be improved and see if the documentation needs additional updates.

karlp commented 2 years ago

It looks like you've got v5 support in the general functions, and also _v5 suffixed functions? Does that really make it easier to use? In general this looks ok though, I've not tried any of it out though.

niecore commented 2 years ago

It looks like you've got v5 support in the general functions, and also _v5 suffixed functions? Does that really make it easier to use? In general this looks ok though, I've not tried any of it out though.

Yes you are right, I wanted to share some code but since this already lead to confusions, I changed the functionality now, so that the old functions are not touched.

karlp commented 2 years ago

It looks like you've got v5 support in the general functions, and also _v5 suffixed functions? Does that really make it easier to use? In general this looks ok though, I've not tried any of it out though.

Yes you are right, I wanted to share some code but since this already lead to confusions, I changed the functionality now, so that the old functions are not touched.

Oh, I'm not against the combined :) I actually suggested it in my issue discussing how this should be done, it just seemed to be not what you had said you had done :)

niecore commented 2 years ago

Hello @karlp , I am wondering If I could provide you anything more in order to help you with the review and merge.