search

flupke / pypotrace

Python bindings for potrace library
Other
166 stars 43 forks source link

Minor fixes to work with Python3 #23

Closed dubnom closed 5 years ago

dubnom commented 5 years ago

Fixed a unicode issue in setup.py and an accidental reference to PyString_FromString (should have been PyUnicode_FromString in _potrace.c.

These changes fixed issues with Python3 and tested on Python 3.7.3.

flupke commented 5 years ago

Hi, thank you for the PR. Did you try https://github.com/flupke/pypotrace/pull/21?

dubnom commented 5 years ago

I just tried #21 and it seems to work great. The build time was quite long, but it works. Any intent to make it Master and release? Thanks - Mike

From: Luper Rouch notifications@github.com Sent: Monday, October 14, 2019 6:37 AM To: flupke/pypotrace pypotrace@noreply.github.com Cc: Michael Dubno michael@dubno.com; Author author@noreply.github.com Subject: Re: [flupke/pypotrace] Minor fixes to work with Python3 (#23)

Hi, thank you for the PR. Did you try #21https://github.com/flupke/pypotrace/pull/21?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/flupke/pypotrace/pull/23?email_source=notifications&email_token=AEFUPCUX7DDJW63JG7MGD6DQORDWJA5CNFSM4JAIKJFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBEDPYY#issuecomment-541603811, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEFUPCXZY6OLCL4ZAGOTOQTQORDWJANCNFSM4JAIKJFA.

flupke commented 5 years ago

Hi, just pushed 0.2 on pypi from #21, thanks for contributing :)

dubnom commented 5 years ago

Thanks for the push, great stuff.

Sent from my iPhone

On Oct 18, 2019, at 6:17 AM, Luper Rouch notifications@github.com wrote:



Closed #23https://github.com/flupke/pypotrace/pull/23.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/flupke/pypotrace/pull/23?email_source=notifications&email_token=AEFUPCSPUUGTEUIMGMT4YZLQPGEKPA5CNFSM4JAIKJFKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUJRBHKY#event-2724336555, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEFUPCXTEONKY3HRDMLLEATQPGEKPANCNFSM4JAIKJFA.