This feature will provide an easy way for converting bitmap object to svg(xml) as string.

[gungoren]

This feature will provide an easy way for converting bitmap object to svg(xml) as string.

12 issue's request will be resolved by this merge.

[gungoren]

@flupke Have you reviewed this PR?

[flupke]

I will review it ASAP

Le jeu. 7 nov. 2019 à 12:10, Mehmet Güngören notifications@github.com a écrit :

@flupke https://github.com/flupke Have you reviewed this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/flupke/pypotrace/pull/24?email_source=notifications&email_token=AABOEISVFNZDCGEQP3ZPYD3QSPZTFA5CNFSM4JGFFMF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDMB4VQ#issuecomment-551034454, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABOEITWKVZLMGABSHN7YMTQSPZTFANCNFSM4JGFFMFQ .

-- Luper Rouch

[gungoren]

Hi,

First of all thanks for your review and this great repos. I hope you will reach more comfortable days ASAP.

I have understand your concerns, If we have move to_xml method from Bitmap to outside, we need to take bitmap and path object as parameters. Until this point there is no any problem. But inside this new method we need to convert path and bitmap objects to cython equalities.

Serialization is done on bitmap object, beacuse we already has cython path and bitmap objects on there.

Renaming file can be done from backend to svg. I have looked it from https://github.com/skyrpex/potrace/blob/master/src/backend_svg.c

If you can be of any further assistance, please let me know.

Regards, Mehmet

[kolibril13]

Hello, I am using jupyter notebooks to convert images to binary images, and there is just no tool yet to directly save svgs at this point. I think this pull request would help a lot of people to do so! See also: https://stackoverflow.com/questions/31427903/convert-png-to-svg-using-python Thanks for your work and your effort. For me, this will be a very useful tool to use and I am looking forward for this merge :+1:

[flupke]

I understand the need but, as I said, I'm not comfortable with merging it in its current state, sorry.

Closing the PR for no activity, please don't hesitate to reopen if you want to discuss further or push new changes.

[kolibril13]

Are there any updates on this idea? Or if not, do you any other tool to convert images into svg files with only pure python? Thanks a lot!

[flupke]

Hi @kolibril13, I'm really sorry but I'm not comfortable merging this PR in its current state. Please see my comment for the details on how I see how this should be implemented. Unfortunately I don't have time to work on this at the moment.

[kolibril13]

Ok, thanks for your reply!