search

flupke / pypotrace

Python bindings for potrace library
Other
166 stars 43 forks source link

pypotrace and python 3.8 #29

Closed waterphenix closed 4 years ago

waterphenix commented 4 years ago

I just try to make pypotrace working with python 3.8 using pip : no way ! So I decide to clone repository and do it myself.

Just changing 3 lines in potrace/_potrace.pyx seem do the job : In line 122, 359 and 361, changing / by // make things work.

I don't know how to make a pull request so... If anybody can do it and push it on pip.

Thanks in advance and sorry for my bad english.

Ckln commented 4 years ago

Thank you sooo much ! I'll do a PR

waterphenix commented 4 years ago

Thanks alot.

Just a question, when I do python setup.py build_ext --inplace I get some warning.

Many are deprecation warning, some pointer to int casting and int in bool context. All in potrace/_potrace.c.

When I open it, I saw in first line /* Generated by Cython 0.28.6 */. Is this mean I can't manually fix them ?

flupke commented 4 years ago

Yes, the .c files are generated on the fly by Cython. The numpy warnings could be fixed by using the proper API, but there is nothing we can do about the ones that come from the way Cython generates its code.

Le ven. 24 avr. 2020 à 08:46, waterphenix notifications@github.com a écrit :

Thanks alot.

Just a question, when I do python setup.py build_ext --inplace I get some warning.

Many are deprecation warning, some pointer to int casting and int in bool context. All in potrace/_potrace.c.

When I open it, I saw in first line / Generated by Cython 0.28.6 /. Is this mean I can't manually fix them ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flupke/pypotrace/issues/29#issuecomment-618834270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABOEIQZRWAITB37TUM5VG3ROEYVDANCNFSM4MNJG25Q .

-- Luper Rouch