search

flupke / rainbow-saddle

A wrapper around gunicorn to handle graceful restarts correctly
48 stars 12 forks source link

Enhancement proposal - do not restart gunicorn on rainbow-saddle restart #12

Open gbataille opened 7 years ago

gbataille commented 7 years ago

Do not restart gunicorn when rainbow-saddle is restarted.

The whole point of rainbow-saddle is to never interrupt gunicorn. However in the (albeit rare) event that rainbow-saddle is updated, both rainbow-saddle and gunicorn needs to be restarted.

What would you think if in the case a gunicorn pid is passed as a param, and the file exists and the process exists (and contains gunicorn in its command, just to be sure), rainbow-saddle does not start gunicorn on startup but rather starts managing the existing gunicorn process

I would be happy to try and code it if you are open to the idea and to PR :)

flupke commented 7 years ago

Sure go ahead :)

Le jeu. 16 mars 2017 à 15:50, Gregory Bataille notifications@github.com a écrit :

Do not restart gunicorn when rainbow-saddle is restarted.

The whole point of rainbow-saddle is to never interrupt gunicorn. However in the (albeit rare) event that rainbow-saddle is updated, both rainbow-saddle and gunicorn needs to be restarted.

What would you think if in the case a gunicorn pid is passed as a param, and the file exists and the process exists (and contains gunicorn in its command, just to be sure), rainbow-saddle does not start gunicorn on startup but rather starts managing the existing gunicorn process

I would be happy to try and code it if you are open to the idea and to PR :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/flupke/rainbow-saddle/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AALiIv340QPLqa2bkTQoIYAXNBAhMhv3ks5rmUxKgaJpZM4MfaYi .