search

fluree / core

Fluree releases and public bug reports
0 stars 0 forks source link

decide on clojure testing conventions #73

Open dpetran opened 6 months ago

dpetran commented 6 months ago

Following up on the discussion in https://github.com/fluree/server/pull/30

We should decide on what conventions we should use for testing and then use them going forwards.

cap10morgan commented 6 months ago

Specifically what the second argument to the clojure.test/is fn should be used for. The official docs imply that it should state / clarify the purpose of the test, but the example is kind of unhelpful because the test in question is so simple it needs no restatement / clarification of its purpose. In addition, the messages are only seen on test failure, so I had been using them to supply additional information that is helpful in determining why a test failed (e.g. the entire HTTP response map when a test like (is (= 200 (:status response))) fails). I would like to see that practice continued / universalized or something similar that is also helpful along those lines.