search

flurrybox / enhanced-privacy

Magento 2 Enhanced Privacy extension for easier compliance with GDPR. Allows customers to delete, anonymize, or export their personal data.
https://flurrybox.com
GNU General Public License v3.0
43 stars 11 forks source link

Cookie Policy Popup display when is not enable #6

Open przemyslawdziadek opened 5 years ago

przemyslawdziadek commented 5 years ago

Hi. I find a bug in Block/Customer/PrivacyPopup.php file.

the function 

protected function _toHtml()
{
        if (
            !$this->privacyHelper->isModuleEnabled() &&
            !$this->privacyHelper->isPopupNotificationEnabled()
        ) {
            return '';
        }
        return parent::_toHtml();
}

I think it should look like this:

protected function _toHtml()
{
        if (
            !$this->privacyHelper->isModuleEnabled() ||
            !$this->privacyHelper->isPopupNotificationEnabled()
        ) {
            return '';
        }
        return parent::_toHtml();
}

because when if clausule looks like this !$this->privacyHelper->isModuleEnabled() && !$this->privacyHelper->isPopupNotificationEnabled() then popup display when is not enable in settings.