flutter-form-builder-ecosystem / form_builder_extra_fields

Additional ready-made form input fields for flutter_form_builder package
https://pub.dev/packages/form_builder_extra_fields
BSD 3-Clause "New" or "Revised" License
28 stars 47 forks source link

upgraded intl to 19 #109

Closed jhaglund closed 3 months ago

jhaglund commented 3 months ago

Connection with issue(s)

Close #??? Closes half of 106, but not flutter_type_ahead

Connected to #???

Solution description

Screenshots or Videos

To Do

jhaglund commented 3 months ago

This just upgrades the intl dependency from 0.18.1 to 0.19.0

deandreamatias commented 3 months ago

Probably need to apply the same things that this PR https://github.com/flutter-form-builder-ecosystem/form_builder_validators/pull/94/files Mainly

environment:
  sdk: ^3.4.0
  flutter: ">=3.22.0"
jhaglund commented 3 months ago

Locally, I additionally changed the pubspec.yaml to point at github's updated form_builder_validators instead of getting from pub.dev. Of course, I didn't check that change in. But it works for me. Pub.dev needs the updated form_builder_validators

jhaglund commented 3 months ago

I just realized, the pubspec.lock (but not yaml) points to my github repo to resolve the updated form_builder_validators. I think this will be OK -- local repos will overwrite this as soon as someone runs pub get but ideally I guess form_builder_validators should be in pub.dev ASAP. But pubspec.yaml is what matters, so I think it's fine. But worth noting

jhaglund commented 3 months ago

I'm getting errors involving flutter_colorpicker, looking into it, don't merge, thanks!

jhaglund commented 3 months ago

Ok, after running pub upgrade, the colorpicker problem went away. I think this is OK to merge, but ideally form_builder_validators would be published in pub.dev. Either way works for me, thanks!

deandreamatias commented 3 months ago

@jhaglund form_builder_validators version 10.0 with intl 0.19 published

Sumit258000 commented 3 months ago

@deandreamatias any plans for intl dependency upgrade in form_builder_extra_fields plugin also? If needed I can make pull request for the same.Thanks.

himankBellpost commented 3 months ago

any plans for intl dependency upgrade in form_builder_extra_fields. in how many days we can expect the same?

deandreamatias commented 3 months ago

First we need update flutter_form_builder and launch to pub.dev and after that, merge this MR and release a new version

deandreamatias commented 3 months ago

I've tried to fix the lints warnings to pass pipeline, but I can't modify files that isn't modified by @jhaglund before

jhaglund commented 3 months ago

but I can't modify files that isn't modified by @jhaglund before

@deandreamatias let me know if you need any assistance. I just pushed changes to implement the changes recommended by the flutter analyze messages (so build workflow should run without errors)

Edit: then I made changes to fix a deprecation warning -- gradle plugins must be declarative based on this https://flutter.dev/go/flutter-gradle-plugin-apply

deandreamatias commented 3 months ago

We step forward to next error XD Now need add to changelog all changes until the last generated release (10.1.0)