Closed grundid closed 2 years ago
Maybe need added a description that when use typeSelectors
, type
and selector
don't be used by this widget. A code verification (assert) should be nice too
Maybe need added a description that when use
typeSelectors
,type
andselector
don't be used by this widget. A code verification (assert) should be nice too
I guess an assertion will not work here since type
and selector
both have default values. Maybe it would be better to deprecate type
and selector
and put the current values into typeSelectors?
Seems ok for me. Can add a @deprecated
with a message in type
and selector
properties and add a documentation to readme with this new behaviour.
In first time, I release a minor version with this. When will has more change, I can release a major update and remove this deprecated properties
You want me to add something or is the current version OK?
@grundid please add this
type
and selector
properties readme
about this deprecated properties and how typeSelectors
replace this deprecated propertiesThanks a lot!
@grundid When you can, please update the main example Thanks
Added description for the new field typeSelectors.