flutter-form-builder-ecosystem / form_builder_validators

Form Builder Validators is set of validators for FormFields. It provides common validators and a way to reuse multiple validators
https://pub.dev/packages/form_builder_validators
BSD 3-Clause "New" or "Revised" License
52 stars 98 forks source link

Align between #123

Closed martijn00 closed 4 months ago

martijn00 commented 4 months ago

Connection with issue(s)

Close #120

Solution description

I cannot reproduce that min and max are switched.

Screenshots or Videos

To Do

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.02%. Comparing base (da39169) to head (4f55489).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ========================================== + Coverage 95.00% 95.02% +0.01% ========================================== Files 92 92 Lines 1002 1006 +4 ========================================== + Hits 952 956 +4 Misses 50 50 ``` | [Flag](https://app.codecov.io/gh/flutter-form-builder-ecosystem/form_builder_validators/pull/123/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flutter-form-builder-ecosystem) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flutter-form-builder-ecosystem/form_builder_validators/pull/123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flutter-form-builder-ecosystem) | `95.02% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flutter-form-builder-ecosystem#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martijn00 commented 4 months ago

@deandreamatias this can be merged. I'll rebase my other PR after this is merged.

martijn00 commented 4 months ago

@deandreamatias any other feedback?