include generated l10n, they are not auto-generating for published package

flutter-form-builder-ecosystem / form_builder_validators

Form Builder Validators is set of validators for FormFields. It provides common validators and a way to reuse multiple validators

https://pub.dev/packages/form_builder_validators

BSD 3-Clause "New" or "Revised" License

49 stars 98 forks source link

include generated l10n, they are not auto-generating for published package #98

Closed jhaglund closed 3 months ago

jhaglund commented 3 months ago

Generated these with flutter gen-l10n

Connection with issue(s)

Close #97

Connected to #???

Solution description

Screenshots or Videos

The previous commit removed these files and took them out of version management. That might make sense long term, to have them generated more frequently, but they are not being auto-generated. So here they are.

To Do

[x] Read contributing guide
[x] Check the original issue to confirm it is fully satisfied
[x] Add solution description to help guide reviewers
[ ] Add unit test to verify new or fixed behaviour
[ ] If apply, add documentation to code properties and package readme

martijn00 commented 3 months ago

The question is why the files are not included when the CD build is being made. It is done here: https://github.com/flutter-form-builder-ecosystem/form_builder_validators/blob/main/.github/workflows/base.yaml#L89

This PR is not a proper fix and the CI should be fixed instead.

deandreamatias commented 3 months ago

The question is why the files are not included when the CD build is being made. It is done here: https://github.com/flutter-form-builder-ecosystem/form_builder_validators/blob/main/.github/workflows/base.yaml#L89

This PR is not a proper fix and the CI should be fixed instead.

Because add to gitignore, automatically ignore by pub dev

martijn00 commented 3 months ago

Yeah, but the question is why. Is there no option to include it?