flutter-form-builder-ecosystem / phone_number

Flutter plugin for parsing, formatting and validating international phone numbers.
https://pub.dev/packages/phone_number
BSD 3-Clause "New" or "Revised" License
81 stars 63 forks source link

Web Support #44

Open VictorUvarov opened 3 years ago

VictorUvarov commented 3 years ago

Apparently Google's libphonenumber is also a JavaScript library. I assume it might also support Flutter web.

deandreamatias commented 2 years ago

Maybe this library can help with this

iamsahilsonawane commented 2 years ago

@nashfive This is a must-have thing. None of the packages on pub.dev I see for phone number parsing, validation and internationalization. We need to work on this.

I'll be starting to work on this sooner I guess, please let me know if there's work already started?

nashfive commented 2 years ago

Hi @iamsahilsonawane,

I agree that the web support would be a great addition.

There is indeed an opened (and old) pull request that was implementing this somehow. It has never been merged as it requires thorough testing. Also, the architecture of the plugin itself is old and doesn't follow the modern Flutter standards anymore (platform separation, etc.)

As I am not working with Flutter anymore, I am not providing support anymore for this plugin. I am willing to transfer the ownership to anyone who is willing to take over its development. Let me know if you're interested ?

deandreamatias commented 2 years ago

Hi @nashfive! Thanks for answer. Others devs and me start working in a new organization to provide flutter form solutions. You can see discussion about this here.

In one of form solutions (form_builder_phone_field), we use this plugin to build it.

It would be nice transfer this ownership to this organization. We can add @iamsahilsonawane like collaborator if he want

iamsahilsonawane commented 2 years ago

@nashfive Thanks for the comment. I would definitely want to take charge of this and was going to study the plugin code to understand if I would be a great fit or not for this plugin.

And as per @deandreamatias 's comment, yes I would be happy to be a part of collaborating with them 👍🏻

nashfive commented 2 years ago

Hi @deandreamatias

I like the idea! Would it be still possible for users to install/use the phone_number plugin directly without using the form_builder_phone_field package?

deandreamatias commented 2 years ago

@nashfive Yeah yeah, of course. My idea is maintain this repo like currently, separated and like one more dependency of form_builder_phone_field

iamsahilsonawane commented 2 years ago

Let me know guys when you're ready to do something about transferring the ownership. @deandreamatias I'll be happy to help!

deandreamatias commented 2 years ago

@iamsahilsonawane I sent you a invite to organization 🚀

nashfive commented 2 years ago

In order to be able to transfer the ownership, I need to be invited to the the Flutter Form Builder Ecosystem organization, as well as its associated pub.dev's publisher.

deandreamatias commented 2 years ago

We don't have a pub.dev publisher associated with this organization yet :( At moment, all form packages is published by @danvick

nashfive commented 2 years ago

I've transferred the repo to the organization already. It seems that I can only transfer the plugin on pub.dev to an existing publisher, and I need to be a member of that publisher as well 🤔

nashfive commented 2 years ago

@iamsahilsonawane @deandreamatias While waiting for a valid publisher on your end, I should probably invite you guys in my publisher team so you can publish new versions of the plugin. Is that for with you? can you provide me the emails you use for pub.dev?

deandreamatias commented 2 years ago

I need discuss with others devs the best solution to create a organization publisher. My email on pub.dev is deandreamatias@gmail.com. I has my own publisher, I don't know if this is a problem

iamsahilsonawane commented 2 years ago

I think we should be good with this. Though, I'll let @deandreamatias comment on this one.

Besides, iamsahilsonawane@gmail.com is my email.

nashfive commented 2 years ago

Ah ok, it's definitely not a problem I think. I've added you Dean to my publisher. You can even transfer the plugin to yours whenever you see fit.

iamsahilsonawane commented 2 years ago

Ah ok, it's definitely not a problem I think. I've added you Dean to my publisher. You can even transfer the plugin to yours whenever you see fit.

Sure thanks 👍

iamsahilsonawane commented 2 years ago

@deandreamatias Can you please revert back to the email? I've mailed you regarding planning stuff out

SavvyBud commented 1 year ago

Does this library support web? I keep getting error: MissingPluginException(No implementation found for method parse on channel com.julienvignali/phone_number)

loic-hamdi commented 1 year ago

Any update?

iamsahilsonawane commented 1 year ago

I've been very busy lately with some unignorable tasks. It will take a bit of time for me to start on this. If anyone's interested in working on that, pull requests are welcomed. Or if not, I'll work on this in some days.

@deandreamatias I'll need your help in migrating to the federated plugin as soon you're available as well, so we can proceed with working on future updates and platform support without any issues.

deandreamatias commented 1 year ago

I might can help answer some questions and things related to architecture, but I also don't have time to develop this package right now. First I (really) need finish a migration in my personal project, that was starting 9 months ago (melting face emoji)

loic-hamdi commented 1 year ago

I might can help answer some questions and things related to architecture, but I also don't have time to develop this package right now. First I (really) need finish a migration in my personal project, that was starting 9 months ago (melting face emoji)

How is going the tv-randshow project? :)

deandreamatias commented 1 year ago

@loic-hamdi tv-randshow done. Now I have another project on personal life. I made a comment about this plugin. Take a look here https://github.com/flutter-form-builder-ecosystem/phone_number/issues/102#issuecomment-1536556043