Set explicit default values in GeolocateControlOptions

flutter-mapbox-gl / maps

A Mapbox GL flutter package for creating custom maps

Other

1.04k stars 503 forks source link

Set explicit default values in GeolocateControlOptions #1370

Closed sdabet-orpheo closed 11 months ago

sdabet-orpheo commented 1 year ago

As a follow-up of https://github.com/flutter-mapbox-gl/maps/pull/1260, set default values for timeout and maximumAge, with respect to https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/getCurrentPosition#syntax.

sdabet-orpheo commented 1 year ago

Does the JsObjectWrapper always expect a timeout? Can this be a default value for it as well? If so if this is meant to be a default, it could be set as default to the PositionOptions class itself instead.

I have made a pull request on mapbox-gl-dart to set default values in PositionOptions, but the repository doesn't seem active anylonger.

stale[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.