search

flutter-ml / google_ml_kit_flutter

A flutter plugin that implements Google's standalone ML Kit
MIT License
930 stars 707 forks source link

Doesn't support AGP 8 #509

Closed DanMossa closed 11 months ago

DanMossa commented 1 year ago

Getting the error:


* What went wrong:
A problem occurred configuring project ':google_mlkit_commons'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

Pretty sure we just need to add a 

    if (project.android.hasProperty("namespace")) {
        namespace 'com.google_mlkit_commons'
    }
fbernaly commented 1 year ago

@DanMossa : how do you reproduce this error? How did you test the fix?

DanMossa commented 1 year ago

I updated my gradle to the latest version and clicked sync after I made changes

IAmJulianAcosta commented 10 months ago

Hi, do we have an ETA of when this is going to be released?

fbernaly commented 10 months ago

working on it, this week