search

flutter-ml / google_ml_kit_flutter

A flutter plugin that implements Google's standalone ML Kit
MIT License
907 stars 709 forks source link

fix: Updated text recognition dependency #613

Closed Mikkelet closed 2 months ago

Mikkelet commented 2 months ago

Update dependency to fix restraints bug from https://github.com/flutter-ml/google_ml_kit_flutter/issues/612

fbernaly commented 2 months ago

@Mikkelet: where did you find that latest dependencies? I am in the process of releasing a new version. Could you also update the podspecs for the other plugin as well.

fbernaly commented 2 months ago

Also, update your branch with the latest code we just merged.

Mikkelet commented 2 months ago

Yeah their website doc is lacking, had to go into their sample apps to get the right version:

https://github.com/googlesamples/mlkit/tree/master/ios/quickstarts https://github.com/googlesamples/mlkit/blob/master/ios/quickstarts/vision/Podfile

I can see you've commented-out the dependency of Document Scanner and FaceMeshDetection. I couldn't find any versions for these in the sample apps, so I assume they're only available for Android?

fbernaly commented 2 months ago

They are no available for iOS yet, only android.

fbernaly commented 2 months ago

Thanks for your contribution. I am merging this, and releasing on Monday.

fbernaly commented 2 months ago

@Mikkelet: I tried to run those with the example app and it is not able to find version 6.0.0, it finds 5.0.0. Did you test the changes with the example app? give it a try an update accordingly. Submit a new PR with the changes.

Mikkelet commented 2 months ago

ah no, sorry, I assumed that the versions used in the official sample apps would be correct, but I can see now that they are not.. or rather, they wont compile in the example project at least.

I also tried with going back to my initial commit where I only updated the version for text-recognition, but something weird is happening. When I update to 6.0.0, I can compile my flutter project, but not the example project. When I downgrade to 4.0.0, I can compile the example project, but not my personal project. Any clues to why that is?

fbernaly commented 2 months ago

Try 5.0.0 that works in the example. Send a PR with those changes.