Migrated package and sample to Null Safety

flutter-studio / flutter-icons

Customizable Icons for Flutter :boom:

Apache License 2.0

332 stars 123 forks source link

Migrated package and sample to Null Safety #42

Closed adarsh-technocrat closed 3 years ago

adarsh-technocrat commented 3 years ago

Would prefer to create another branch for null safety :)

Thank you! fixed issue #41

joaovvrodrigues commented 3 years ago

hoping it will be merged to main.

adarsh-technocrat commented 3 years ago

hoping it will be merged to main.

Ok, @joaovvrodrigues, not an issue if directly want to merge to the main branch I will change the base branch to the main branch instead of the master you will able to merge the PR in main in that case :)

adarsh-technocrat commented 3 years ago

hoping it will be merged to main.

Ok, @joaovvrodrigues, not an issue if directly want to merge to the main branch I will change the base branch to the main branch instead of the master you will able to merge the PR in main in that case :)

I think there is no main branch in the repo!

princeteck commented 3 years ago

What is the status for Null Safety here ? I am stuck with :

Error: Cannot run with sound null safety, because the following dependencies
don't support null safety:

- package:flutter_icons

For solutions, see https://dart.dev/go/unsound-null-safety

lcsvcn commented 3 years ago

@princeteck Same thing. Hope this will be merged soon to have everything sound null safety :)

adarsh-technocrat commented 3 years ago

What is the status for Null Safety here ? I am stuck with :

Error: Cannot run with sound null safety, because the following dependencies
don't support null safety:

- package:flutter_icons

For solutions, see https://dart.dev/go/unsound-null-safety

Hey @princeteck @lcsvcn you can use this snippet


flutter_icons:
  git:
     url: https://github.com/adarsh-technocrat/flutter-icons

as this will resolve your issue just wait for the PR merge then you can use the official null-safety version of the package :)

just look related PR issue comment thread #41

lcsvcn commented 3 years ago

Hi guys, I don't know is currently maintaining this, but would be nice to merge this when possible to have available at pub.dev. Thank you. @flutter-studio @2534290808 @udiedrichsen @Slackboi

lcsvcn commented 3 years ago

Also, it would be very nice to add another maintainers to help keep this project updated. You could open an issue to find active maintainers wanting to help you keep this awesome project. Just a suggestion :) Thanks!

ajaygautam commented 3 years ago

This is the only non null-safe package in my app. Would love to get this asap.

aytunch commented 3 years ago

Hi will this PR be merged soon? just like @ajaygautam this is the last package in our list as well :)

ajaygautam commented 3 years ago

Thanks for the ack. @aytunch Unfortunately, there doesn't seem to be any future for this plugin. The world has seen a lot of tragedy in the last 2 years... not sure whats happening here.

FWIW... I have switched to using https://pub.dev/packages/fluttericon I feel bad abandoning this plugin... but... the show must go on.

adarsh-technocrat commented 3 years ago

I don't know if this PR is going to merge!