search

flutter-studio / flutter-icons

Customizable Icons for Flutter :boom:
Apache License 2.0
332 stars 123 forks source link

Migrate to null safety #47

Open jibiel opened 3 years ago

jibiel commented 3 years ago

9cf4b48 fixes the majority of the analyzer warnings (mostly redundant const declarations).

0889610 migrates the package to null safety.

Notes:

Please consider this PR for release, because the package complicates migration to null safety for the apps that using it.

Fixes #41. Fixes #45. Fixes #46.

nehal076 commented 3 years ago

Please merge this PR

alekoleg commented 3 years ago

Can you take a look guys, @2534290808 , @udiedrichsen @Slackboi please?

Xezolpl commented 3 years ago

Merge Please 🙏

pxsanghyo commented 3 years ago

@jibiel Thanks for the PR I'll override dependency with your PR repo for now.. please don't delete until merged :)

dependency_overrides:
  # Required for null-safety
  # PR: https://github.com/flutter-studio/flutter-icons/pull/47
  flutter_icons:
    git:
      url: git://github.com/jibiel/flutter-icons.git
      ref: master
mac-spinks commented 3 years ago

When will this be merged in? Waiting for this to migrate my app to null safety

pelusodan commented 3 years ago

Super looking to get this merged

mac-spinks commented 3 years ago

Pull request has been here for a month now. When can we expect this to be merged?

josephcrowell commented 3 years ago

One pull request has been sitting on this repo for almost 2 years...

fabioselau077 commented 3 years ago 
github.com/jibiel/flutter-icons.git

flutter pub get Warning: You are using these overridden dependencies:
! flutter_icons 2.0.0 from git git://github.com/jibiel/flutter-icons.git at 088961 Running "flutter pub get" in app_jason...

josephcrowell commented 3 years ago

@jibiel would you be willing to take over maintenance on this repo with your fork? Renamed to flutter-vector-icons and added to pub.dev under that name of course.

jibiel commented 3 years ago

@josephcrowell

Not sure I'm very motivated and interested to do so.

Since the PR was opened I've switched to a more modular vendor packages — cupertino_icons and ionicons. And I think this may be a more correct approach. Ideally, it should be one set. But often there are some required icons missing, of course.

Don't know how this all will compile in the final build yet, but the package takes 16MB unpacked and knowing that you include dozen of fonts and thousands of icons in the app and using only 1-5% of them is kinda strange.

You are free to use the code from my fork however you see fit, though.

josephcrowell commented 3 years ago

Cheers

josephcrowell commented 3 years ago

I pushed out a fork which includes all missing icons including Fontisto fonts and jibiel's fixes for null safety support: https://pub.dev/packages/flutter_font_icons

gurulnd-git commented 2 years ago

I pushed out a fork which includes all missing icons including Fontisto fonts and jibiel's fixes for null safety support: https://pub.dev/packages/flutter_font_icons

Thanks, I thought of doing so. We'll keep using flutter_font_icons and do make someone like me as contributer, so that we can keep that alive