flutter-tizen / engine

The Flutter engine
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
6 stars 19 forks source link

Handle special key events for TV remote controls #232

Closed swift-kim closed 2 years ago

swift-kim commented 2 years ago

A temporary fix for https://github.com/flutter-tizen/flutter-tizen/issues/319. May also fix https://github.com/flutter-tizen/engine/issues/229.

I don't have an access to TV devices right now. Could anybody test this change on a real TV device?

Things to test:

How to test (details):

$ TIZEN_ENGINE_GITHUB_RUN_ID=1718348087 flutter-tizen precache --tizen
$ flutter-tizen run --verbose-system-logs
xiaowei-guan commented 2 years ago

when I don't apply this patch, I can't reproduce Play/Pause button issue on TV device.

when I apply this patch on TV device, no channel list and play/pause issue, but still has menu button issue:

swift-kim commented 2 years ago

@xiaowei-guan Thanks for the check. I'll check again and provide a better solution after the holidays :)

swift-kim commented 2 years ago

Closing in favor of https://github.com/flutter-tizen/engine/pull/234.

@xiaowei-guan You can test the new PR if you want to check if https://github.com/flutter-tizen/engine/issues/229 has been resolved.