Closed swift-kim closed 2 years ago
I decided not to apply https://github.com/flutter-tizen/engine/issues/221 right now because it adds too much complexity without much benefit.
We still need to implement it in the near future in order to enable more key mapping (currently only keys that are listed in kGtkToLogicalKey
are supported).
After applying this PR, I confirmed that the "Not available" popup no longer appears on my TV with devel board
@swift-kim, is there a reason it goes into Flutter 2.10 and not in 2.8? Can this be done for 2.8 as well?
@AliaksandrTuzik We usually support only one Flutter version at a time (i.e. the flutter-tizen tool follows a linear versioning policy) to reduce maintenance workload and do not provide updates for older versions. However as https://github.com/flutter-tizen/flutter-tizen/pull/326 has not been merged yet, we can release this patch for Flutter 2.8 first and then finish the migration to Flutter 2.10, if you want. How do you think?
@AliaksandrTuzik We usually support only one Flutter version at a time (i.e. the flutter-tizen tool follows a linear versioning policy) to reduce maintenance workload and do not provide updates for older versions. However as flutter-tizen/flutter-tizen#326 has not been merged yet, we can release this patch for Flutter 2.8 first and then finish the migration to Flutter 2.10, if you want. How do you think?
That would be great!
Fixes https://github.com/flutter-tizen/flutter-tizen/issues/319. Substitutes the previous change https://github.com/flutter-tizen/engine/pull/232.
Changes
XF86AudioPlayPause
) be redefinable by the app.ecore_wl2_window_keygrab_set
andeext_win_keygrab_set
were used to override the system's default behavior.efl-extension
dependency (foreext_win_keygrab_set
).RawKeyEvent.character
.KeyEventHandler::OnKey
returnECORE_CALLBACK_DONE
(instead ofECORE_CALLBACK_PASS_ON
) by default.modifierMeta
(1 << 28
to1 << 26
).Cleanups
key
→event
).key_event_handler.cc
andtouch_event_handler.cc
analogous to each other.To test this PR (details):