flutter-tizen / engine

The Flutter engine
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
6 stars 19 forks source link

Improve key event handling for TV remote controls #234

Closed swift-kim closed 2 years ago

swift-kim commented 2 years ago

Fixes https://github.com/flutter-tizen/flutter-tizen/issues/319. Substitutes the previous change https://github.com/flutter-tizen/engine/pull/232.

Changes

Cleanups

To test this PR (details):

$ TIZEN_ENGINE_GITHUB_RUN_ID=1804716824 flutter-tizen precache --tizen
$ flutter-tizen run --verbose-system-logs
swift-kim commented 2 years ago

I decided not to apply https://github.com/flutter-tizen/engine/issues/221 right now because it adds too much complexity without much benefit.

We still need to implement it in the near future in order to enable more key mapping (currently only keys that are listed in kGtkToLogicalKey are supported).

bbrto21 commented 2 years ago

After applying this PR, I confirmed that the "Not available" popup no longer appears on my TV with devel board

Aliaksandr-Tuzik commented 2 years ago

@swift-kim, is there a reason it goes into Flutter 2.10 and not in 2.8? Can this be done for 2.8 as well?

swift-kim commented 2 years ago

@AliaksandrTuzik We usually support only one Flutter version at a time (i.e. the flutter-tizen tool follows a linear versioning policy) to reduce maintenance workload and do not provide updates for older versions. However as https://github.com/flutter-tizen/flutter-tizen/pull/326 has not been merged yet, we can release this patch for Flutter 2.8 first and then finish the migration to Flutter 2.10, if you want. How do you think?

Aliaksandr-Tuzik commented 2 years ago

@AliaksandrTuzik We usually support only one Flutter version at a time (i.e. the flutter-tizen tool follows a linear versioning policy) to reduce maintenance workload and do not provide updates for older versions. However as flutter-tizen/flutter-tizen#326 has not been merged yet, we can release this patch for Flutter 2.8 first and then finish the migration to Flutter 2.10, if you want. How do you think?

That would be great!