search

flutter-tizen / engine

The Flutter engine
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
6 stars 19 forks source link

[ci] Update gn arguments #235

Closed swift-kim closed 2 years ago

swift-kim commented 2 years ago

Flutter 2.10's new build-embedder-examples flag should be explicitly disabled for our builds.

WonyoungChoi commented 2 years ago

It seems to need vulkan.... please try again after removing below line. https://github.com/flutter-tizen/engine/blob/8245e5ac163b0f2273f786f021c46f511d979124/ci/tizen/gclient-prepare-sync.sh#L79

swift-kim commented 2 years ago

Hmm. I wonder why Vulkan has suddenly become a dependency of the engine. I'll check.

swift-kim commented 2 years ago

The issue was caused by: https://github.com/flutter/engine/commit/bba38c0b83122ec9b174271e74499d739416208b

We can simply disable the Vulkan backend by adding 'linux' to this line but I didn't do so and just added Vulkan back to DEPS because compiling Vulkan didn't really increase the engine binary size.