Add high contrast accessibility support for TV

flutter-tizen / engine

The Flutter engine

https://flutter.dev

BSD 3-Clause "New" or "Revised" License

6 stars 19 forks source link

Add high contrast accessibility support for TV #237

Closed zhouleonlei closed 2 years ago

zhouleonlei commented 2 years ago

Add accessibility high contrast in TV menu settings

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I signed the CLA.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

swift-kim commented 2 years ago

The code is good, but the "high contrast" option from the TV settings and Flutter's "bold text" accessibility feature do not seem to match by their meaning. In the framework, they are two different concepts:

Have you considered other ways to enable the feature? The most desirable way I can think of right now is to add the missing kFlutterAccessibilityFeatureHighContrast flag to the embedder API and send a PR to the upstream.

swift-kim commented 2 years ago

Another question: Will this change work out of the box without having to change any app code (Dart)?

zhouleonlei commented 2 years ago

Another question: Will this change work out of the box without having to change any app code (Dart)?

No need to modify codes in App side.

swift-kim commented 2 years ago

Let's merge this for now.

I heard from @zhouleonlei that turning on the high contrast mode on TV enables both bold text and dark background for native apps. Flutter apps should be affected in the same way, but this PR enables bold text only. Let's see if we can add the highContrast (dark background) option to the embedder API in the future.

swift-kim commented 2 years ago

Cherry-picked into the flutter-2.10.1-tizen branch: dba8fffffffcd46b8cb4df6ff0949a7a927f51c0.