Refactor SettingsChannel - Githubissues

flutter-tizen / engine

The Flutter engine

https://flutter.dev

BSD 3-Clause "New" or "Revised" License

6 stars 19 forks source link

Refactor SettingsChannel #249

Closed swift-kim closed 2 years ago

swift-kim commented 2 years ago

Remove settings_channel_tizen.cc and merge into settings_channel.cc.
Small refactoring (remove Init and Dispose, inline OnSettingsChangedCallback, make SendSettingsEvent private).
Add an include guard to encodable_value_holder.h.

Contributes to https://github.com/flutter-tizen/engine/issues/239. This change is a continuation of https://github.com/flutter-tizen/engine/pull/248.

Should be rebased after https://github.com/flutter-tizen/engine/pull/248 is merged.