search

flutter-tizen / engine

The Flutter engine
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
6 stars 19 forks source link

[ci] Change the release tag format #287

Closed swift-kim closed 2 years ago

swift-kim commented 2 years ago

As GitHub doesn't any more support a release tag name identical to the target commit hash (404 Not Found error), we need to use a different format for the tag name.

Old: Short commit hash (e.g. abcdefg) New: Engine version + short commit hash (e.g. 3.0.0-abcdefg)

Any suggestion? @flutter-tizen/maintainers

swift-kim commented 2 years ago

There's still no response to my GitHub support ticket, and an action should be made as soon as possible (hopefully today). This change doesn't seem to be a too bad idea.

xuelian-bai commented 2 years ago

looks good to me

HakkyuKim commented 2 years ago

Looks good to me as well, maybe engine.version need to be changed in tools?

swift-kim commented 2 years ago

@HakkyuKim Yes, right. I'll do that in https://github.com/flutter-tizen/flutter-tizen/pull/366 when this PR gets merged.