search

flutter-webrtc / dart-sip-ua

A dart-lang version of the SIP UA stack.
MIT License
339 stars 269 forks source link

Upgrade to video call implementation and dark mode 2 #462

Closed mikaelwills closed 3 months ago

mikaelwills commented 3 months ago

Had to make an adjustment on the first PR, then it started failing some formatter check, hopefully this one cleanly passes the checks.

Added the infrastructure to be able to upgrade a voice call to a video call. This introduced a new listener function to override 'onNewReinvite(ReInvite event)' which is used by the app that uses the package so it can handle the UI for the upgrade request. Also updated the example app to use the upgrade to video functionality.

Added darkmode to the example app.

Refactored how the call screen detects whether it is a voiceOnly call. Previously you could make a video call and the remote side would be told its an audio call. Only when they accept are they suprised to see its a video call. Now on an incoming call it detects if remote has video and for an outgoing call, whether it is video or not is added into the Call object so when you go to call screen you instantly know whether it is voiceOnly or not.

Added optional functionality to terminate the call if the mediaPort is 0. In some cases when you make an audio call and the port is 0 then if the call goes ahead you're not going to get any audio. But theres also the case where you might want to join a conference call without audio. So i made this an option in the Settings object so it can be used for the first case but not interrupt any other cases.

victortive commented 2 weeks ago

My app started freezing about a minute into the call after the PR change. I've had to revert the change