flutter-webrtc / dart-sip-ua

A dart-lang version of the SIP UA stack.
MIT License
339 stars 269 forks source link

naiive way to check for true in maps and config #490

Open reduxdj opened 1 month ago

reduxdj commented 1 month ago

Describe the bug madatory options should expect {"IceRestart": false} should not pass as true Same with renegotiate... { "useUpdate" false"} should not evaluate as true

See renegotiate:

if (options['useUpdate'] != null) 

should be:

 if (options['useUpdate'] != null && options['useUpdate'] == true)

Expected behavior Expected the config to work like any expected configuration

System Infomation() Flutter SDK Version: 3.22 Target OS and Version: N/A Host OS and Version: N/A