search

flutter-webrtc / dart-webrtc

A webrtc interface wrapped in dart language.
MIT License
27 stars 34 forks source link

getRemoteStreams on peerConnection no longer works #44

Closed james-pellow closed 1 month ago

james-pellow commented 2 months ago

Ever since the recent commit titled "chore: remove addstream and removestream events", RTCPeerConnectionWeb.getRemoteStreams has been broken. The _remoteStreams Map is no longer kept up to date so the line: .map((jsStream) => _remoteStreams[jsStream.id]!) always fails. Fortunately this was the only place using _remoteStreams. The issue is that the _jsPc is returning MediaStream from web and we are wanting to return MediaStream from webrtc_interface. What are the long term goals of webrtc_interface? Now that web is accurately defining more webrtc related interfaces, do we still need webrtc_interface? What is the proper fix for this?

james-pellow commented 1 month ago

Any thoughts on this from @cloudwebrtc? Thanks!

james-pellow commented 1 month ago

Should we just revert the commit that broke this?