flutter / devtools

Performance tools for Flutter
https://flutter.dev/docs/development/tools/devtools/
BSD 3-Clause "New" or "Revised" License
1.58k stars 326 forks source link

Support Firefox #492

Closed 12people closed 4 years ago

12people commented 5 years ago

I'd really like to be able to use my browser of choice, Firefox, with Flutter's DevTools.

(Not only that, but I'd also appreciate if web projects in general weren't tied to specific browsers — it hurts web standards and I'd hate another IE-like situation where standards don't matter.)

stevemessick commented 5 years ago

Dup of #66

12people commented 5 years ago

@stevemessick #66 is about displaying messages in unsupported browsers. This bug is about supporting a browser other than Chrome. Two very different things.

stevemessick commented 5 years ago

66 is a pretty extensive discussion about what it takes to support browsers other than Chrome. Including Firefox.

However, I may be mis-interpreting it. I'll let @jacob314 chime in as to whether this should be re-opened.

12people commented 5 years ago

@stevemessick It does mention other browsers, yet the issue at hand is different. That issue comes down to "only Chrome is officially tested, should we display a warning in other browsers?".

This "support Firefox" issue asks, "only Chrome is officially tested, should we still allow it to run DevTools, fix bugs for it, and/or add Firefox to the browsers we test in?" It's about broadening support rather than asking if a warning is needed.

jacob314 commented 5 years ago

Flutter Web will support all modern browsers. If we are able to switch all of this application to use Flutter Web at that point we will begin to support more browsers. Until that point, our time is better spent adding features than making sure we avoid browser compatibility bugs.

Afsar-Pasha commented 5 years ago

@12people Try changing UA string using this addon.

12people commented 5 years ago

@jacob314 I understand your need for effectiveness.

What if DevTools could be opened in Firefox, but there was a dismissable message on first open saying "Firefox is not officially supported. DevTools may not function properly" or something along those lines?

Changing the UA string really feels like I'm going back to IE-incompatibility times and I'd really like to avoid that.

jacob314 commented 5 years ago

I agree that warning that Firefox is not tested but still allowing it to open is fine. The main thing we want to avoid is giving users a bad experience because they accidentally opened the tool with a browser we don't support.

TamasBarta commented 5 years ago

Just curiosity: is there anything specific you know about which feature won't work in Firefox, or you just generally don't trust Firefox?

Edit: I checked, and the tabs' contents don't show up. I'm still curious how could this happen, but OK, looks like Chromium is the way to go for now.

agilob commented 4 years ago

I spoofed UA in firefox using https://addons.mozilla.org/en-US/firefox/addon/user-agent-string-switcher and devtools works fine.

Blend3rman commented 4 years ago

This just feels dirty now. Basically DevTools is simply looking at the useragent string and deciding whether or not to show up. You could merely add a warning banner saying that Firefox support is untested, why do you have to completely disallow running DevTools on Firefox? As far as I have used DevTools it works perfectly fine on FF, seeing as how it's just a regular websocket, which is supposed to be universally supported by all browsers.

I just feel like gatekeeping which browsers users may use is not a good way to go about this.

12people commented 4 years ago

@jacob314 Would you consider reopening this issue? It seems like Devtools work just fine in Firefox and allowing it along with a warning about the browser not being tested would be a good solution for those wanting to use the browser.

Kogia-sima commented 4 years ago

I love Firefox. I hope this will be fixed.

hacker1024 commented 4 years ago

It should be possible to get to the beta Flutter DevTools implementation in Firefox.

Nico04 commented 4 years ago

What about now, with new Flutter release of the Dart Devtools?

devoncarew commented 4 years ago

Re-opening to track up-votes.

kenzieschmoll commented 4 years ago

From some local testing, it looks like firefox may just work now that we are shipping with Flutter.

Nico04 commented 4 years ago

From some local testing, it looks like firefox may just work now that we are shipping with Flutter.

I've just tested myseft, and yes, it seems that it opens in Firefox without any issue nor warning now, that's great !

desthercz commented 4 years ago

It works great, i don't see any reason why we can't set default browser in config. It really feels like unnecessary gatekeeping.

kenzieschmoll commented 4 years ago

transferred request to set default browser to a different issue https://github.com/flutter/devtools/issues/2357. Closing this as fixed.

stagefright5 commented 4 years ago

Also, the official flutter web docs still says you "require" chrome for debugging. Please change it to something like, "we recommend chrome". Here is the link

image

NatoBoram commented 3 years ago

That's because you can't flutter run -d firefox

ghost commented 3 years ago

Is there a way to do It now? It's July 2021, any updates?

NatoBoram commented 3 years ago

Is there a way to do It now?

You can flutter run -d web-server and open it in Firefox, but Dart Debug is not available for Firefox, so no DevTools available either.

It's July 2021, any updates?

No.

silpol commented 3 months ago

It's July 2024 and it's clear now Google is gatekeeping Firefox. If there was will, it could be done with GSoC program so main resources are not engaged. Three years...