flutter / devtools

Performance tools for Flutter
https://flutter.dev/docs/development/tools/devtools/
BSD 3-Clause "New" or "Revised" License
1.58k stars 326 forks source link

Eval hovercard should show evaluation error when eval fails #5336

Open kenzieschmoll opened 1 year ago

kenzieschmoll commented 1 year ago

eval-fail-hover

In the current state, the eval card shows and then is quickly removed when the evaluation fails. As a user, I would want to know that the evaluation failed and not just that DevTools is buggy and broken.

When this same evaluation is done on the console, we see the error: Screenshot 2023-03-01 at 10 46 31 AM

elliette commented 1 year ago

Related: https://github.com/dart-lang/webdev/issues/2009

annagrin commented 1 year ago

Btw in VSCode we just don't show hover cards for failed evals (but do in console eval or a watch window) - otherwise that's too much noise (all the syntax errors would pop up and get sticky when you just move the mouse across the screen)