Enable memory screen in disconnected mode.

flutter / devtools

Performance tools for Flutter

https://flutter.dev/docs/development/tools/devtools/

BSD 3-Clause "New" or "Revised" License

1.53k stars 314 forks source link

Enable memory screen in disconnected mode. #7837

Closed polina-c closed 1 month ago

polina-c commented 1 month ago

We need to enable it before offline data mode to create test automation. Tests cannot flip constant flags. So, we need disconnected mode to be without constant flag.

kenzieschmoll commented 1 month ago

Tests can enable experiments. See example: https://github.com/flutter/devtools/blob/master/packages/devtools_app/test/performance/performance_screen_test.dart/#L138

polina-c commented 1 month ago

Yes, if they are not constants :) In this case enum ScreenMetaData requires constant flag that cannot be flipped by tests.

kenzieschmoll commented 1 month ago

Then we should enable this in the same PR where tests are added. We are doing a beta release today and should not flip this flag to true without proper testing.