Closed polina-c closed 5 days ago
polina-c
commented
1 month ago Added debug logs. Local and bot output is different.
Bots do not show debug logs.
Locally, all lines are executed. There is some internal error that does not stop the test. And test is declared as failed.
polina-c
commented
1 month ago Okay, basic version of the test passes.
But benchmark-performance fails with Caught browser-side error: Instance of 'ProgressEvent'
Reproduced locally. Error:
...
[APP] TEST STATUS: switching to memory screen (icon IconData(U+0F174))
Unrecognized URL path: /assets/img/doc/upload_dark.png
Unhandled exception:
Caught browser-side error: Instance of 'ProgressEvent'Looks strange because the image is rendering well. Tried to list the image explicitly in assets. Did not help.
polina-c
commented
1 month ago Ok, found that in production the image is not rendered:
Fixed.
The fix may be should be applied wider, because some other images may be missed as well. But while we do not know which, let it be just for memory screen. This issue may be a reason to switch golden testing from mac to web, and from debug to release or profile mode, because these parameters may affect the assets availability.
If image is not available in test in profile mode, the test will just fail.
kenzieschmoll
commented
1 month ago I recommend hiding these controls when viewing offline data:
Why? What if user wants to upload another file? What if user imported couple more snapshots, diffed them, updated filter and want to save their work to continue later?
kenzieschmoll
commented
1 month ago What if user imported couple more snapshots, diffed them, updated filter and want to save their work to continue later?
This is a good point. Fine to leave. However, I think the settings (or at least the one related to the console) are irrelevant for offline mode, aren't they?
polina-c
commented
1 week ago Tested disconnect for memory - it works.
Release notes issue: https://github.com/flutter/devtools/issues/7844 I am hitting this error locally: https://github.com/flutter/flutter/issues/145772, every time at different place of the test.