Open elliette opened 3 weeks ago
Would it be possible for LUCI to also change the SDK's DEPs to use that latest version of DevTools, and run the devtools_server tests against it?
@athomas - similar issue to github.com/flutter/devtools/issues/8023, do you know if this might be possible?
FYI @kenzieschmoll
Possible yes, but that's something for the new team. It makes the roller a bit more complex because it will need an SDK checkout. There may also be an out-of-the box solution with the Skia autoroller, but I'm not very familiar with that stack.
devtools_server
and its tests live in the Dart SDK: https://github.com/dart-lang/sdk/blob/main/pkg/dds/lib/devtools_server.dartdevtools_server
tests do not run as part of the test suite when deps are updated in the Dart SDK, which means that when we update thedevtools_rev
, regressions are only caught after submitting (see for example https://github.com/dart-lang/sdk/issues/56111)As a small improvement, having these tests run as part of the pre-submit instead of post-submit would be helpful.
However, it would be even more helpful if we could catch regressions on commits to
flutter/devtools
, so that these regressions are caught when they happen instead of last-minute as part of the release process, requiring cherrypicks to fix (e.g. https://github.com/dart-lang/sdk/issues/56128).Brainstorming about how this could work
Another option is for us to update the DevTools version in the SDK more frequently than during our releases, so that these regressions will be caught sooner.