flutter / devtools

Performance tools for Flutter
https://flutter.dev/docs/development/tools/devtools/
BSD 3-Clause "New" or "Revised" License
1.58k stars 324 forks source link

Fix `integration_test/test/live_connection/eval_and_inspect_test.dart` flake #8123

Closed elliette closed 2 months ago

elliette commented 2 months ago

Work towards https://github.com/flutter/devtools/issues/8013

Tries to fix one of our top integration test flakes:

Evaluation is async since it requires a response from the VM service. I think this test was flaking because we were looking for the eval response in the console too soon. This PR adds and uses a test utility function (retryUntilFound) that will retry looking for a finder with a safePumpDuration in between until the found or there are no more retries.