search

flutter / flutter-intellij

Flutter Plugin for IntelliJ
https://flutter.dev/using-ide
BSD 3-Clause "New" or "Revised" License
1.98k stars 318 forks source link

Make undo easier without popping up Undo reformat code dialog #2847

Open pranayairan opened 5 years ago

pranayairan commented 5 years ago

Steps to Reproduce

Create a dart file, add a few things and save. Now press command Z to undo, you will see an IntelliJ dialog asking you to confirm if you want to undo reformatting of code.

Please tell us what you were doing and what went wrong I am not sure if there is an option to disable it, but every time I undo using a command Z, I get an annoying popup that says undo reformat code. It is not a big deal to press ok but is there any way to disable this dialog?

I think this comes since dart files get auto formatted while saving, but undo is required a lot of time when developing the apps and trying to change things like font size/colors and checking on the device.

Version info

[✓] Flutter (Channel beta, v0.9.4, on Mac OS X 10.13.6 17G65, locale en-US) • Flutter version 0.9.4 at /Users/pairan/flutter • Framework revision f37c235c32 (8 weeks ago), 2018-09-25 17:45:40 -0400 • Engine revision 74625aed32 • Dart version 2.1.0-dev.5.0.flutter-a2eb050044

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3) • Android SDK at /Users/pairan/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • ANDROID_HOME = /Users/pairan/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06) • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 10.1, Build version 10B61 ✗ ideviceinstaller is not installed; this is used to discover connected iOS devices. To install, run: brew install --HEAD libimobiledevice brew install ideviceinstaller • ios-deploy 1.9.2 • CocoaPods version 1.5.2

[✓] Android Studio • Android Studio at /Applications/Android Studio 3.2 Preview.app/Contents ✗ Flutter plugin not installed; this adds Flutter specific functionality. ✗ Dart plugin not installed; this adds Dart specific functionality. • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b04)

[✓] Android Studio (version 3.2) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 30.0.1 • Dart plugin version 181.5656 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.2.6) • IntelliJ at /Users/pairan/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app • Flutter plugin version 27.1.3 • Dart plugin version 182.4129.13

[✓] VS Code (version 1.29.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 2.20.0

[✓] Connected devices (1 available) • Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.0 (API 24) (emulator)

pq commented 5 years ago

@alexander-doroshko : as this would likely be handled in the Dart Plugin, I'm curious if you have any thoughts?

alexander-doroshko commented 5 years ago

I've just fixed a similar usability problem in the Dart plugin (I wonder why nobody has complained for 3+ years :)). But the Flutter-plugin-specific 'Format on Save' feature doesn't reuse the functionality from the Dart plugin. So you'll need to find the cause of the confirmation and fix it on your end separately. Luckily it should be easy to debug.

pq commented 5 years ago

Great. Thanks for following up @alexander-doroshko !

pavel-kalmykov commented 5 years ago

This issue is very annoying! Is there some setting I can change in order to disable the dialog?