Remove the Flutter outline

flutter / flutter-intellij

Flutter Plugin for IntelliJ

https://flutter.dev/using-ide

BSD 3-Clause "New" or "Revised" License

1.95k stars 310 forks source link

Remove the Flutter outline #7398

Open kenzieschmoll opened 2 weeks ago

kenzieschmoll commented 2 weeks ago

The IntelliJ Structure view provides this functionality so we do not need to maintain our own.

helin24 commented 1 week ago

The main difference I see after looking at a few files is having some "wrap with..." buttons here:

I don't see this functionality available elsewhere, but are we okay with not having this any more?

CC @jwren

jwren commented 1 week ago

Yes, this issue was opened when we thought there was no difference in functionality between the Structure view and the Flutter Outline. I suspect that with time functionality like this might come from DevTools and DTD, but for the time being, we should not remove it.

helin24 commented 1 week ago

Okay, thanks for clarifying. For future reference, another thing that I found that is part of the flutter outline is this inline editing panel: https://github.com/flutter/flutter-intellij/pull/4160

kenzieschmoll commented 1 week ago

I don't see this functionality available elsewhere, but are we okay with not having this any more?

These functions are all available as quick fixes, so I don't think the actions at the top should be a blocker to remove.

Screenshot 2024-05-09 at 3 27 03 PM

kenzieschmoll commented 1 week ago

Also, the outline view doesn't seem to load for me. We should add analytics to this view to see if many users are using it: Screenshot 2024-05-09 at 3 31 11 PM

kenzieschmoll commented 1 week ago

Also, the outline view doesn't seem to load for me

Ah, looks like this view is configured to only be enabled when there is a running app, which is a bug. The outline view + Hot UI for that matter should work with now connected app.

helin24 commented 1 week ago

We do have data on the usage of the outline, last week numbers below:

1,000 unique users
8,200 usages of jump to source from the preview
2,000 usages of any of the shortcut actions
3,500 users who have "enabled hot UI" in settings, which allows them to access the inline editing panel. I don't know how many are actually using the panel.

I didn't realize we could open the quick fix menu from the editor - knowing that makes me less reluctant to remove the outline view.

I'm able to see the outline view for some classes in DevTools, e.g. lib/src/screens/inspector/inspector_tree_controller.dart without having an app running, so I'm not sure what's going wrong in your situation. I think at first when I opened a hello flutter app, it wasn't working though, so I believe it's not consistent.

kenzieschmoll commented 1 week ago

I'm able to see the outline view for some classes in DevTools, e.g. lib/src/screens/inspector/inspector_tree_controller.dart without having an app running, so I'm not sure what's going wrong in your situation. I think at first when I opened a hello flutter app, it wasn't working though, so I believe it's not consistent.

Once I killed the app I was running, I still had access to the Flutter Outline view. So maybe it only works after running an app at least once?