search

flutter / flutter-intellij

Flutter Plugin for IntelliJ
https://flutter.dev/using-ide
BSD 3-Clause "New" or "Revised" License
1.98k stars 319 forks source link

Do not reload Tool Windows when theme is changed #7626

Closed kenzieschmoll closed 1 month ago

kenzieschmoll commented 3 months ago

Performing a full reload of the DevTools tool window when the IDE theme is changed is disruptive to the user's workflow and may cause them to lose any debugging data they were looking at before the theme change.

Now that we have DTD to communicate over, we should send an event when the IDE theme changes that DevTools can listen for. DevTools can then update itself for the new IDE theme values.

helin24 commented 2 months ago

There may be some situations where DTD isn't available, e.g. internal usages. Do you have an opinion on whether we should continue to update theme with a refresh or ignore theme changes in those cases? (or something else)

kenzieschmoll commented 2 months ago

If DTD is not available, I recommend we do not update the theme. Having a mismatched theme is a better result than the user potentially losing state in their tool if we force refresh IMO.

helin24 commented 1 month ago

With the latest changes to DevTools this issue is now resolved