Determine which DevTools windows should allow multiple tabs per tool window

[helin24]

Multiple tabs per tool window will appear if there are multiple apps running. This is appropriate for the inspector tool window since each app running could have different widget trees. But I don't think this applies to every page of DevTools, so an audit is appropriate here.

Inspector tool window:

• Multiple tabs possible, one for each app

Other DevTools (performance, CPU profiler, memory, etc):

• Multiple tabs possible, one for each app

Deep links:

• Only one tab
• Should not be associated with an app, i.e. VM service URI should not be appended

Extensions:

• Only one tab
• Should not be associated with an app, i.e. VM service URI should not be appended

@kenzieschmoll is the above correct? I don't know if we need to prioritize cleaning up multi-app support immediately (as it doesn't seem to be used much), but currently I suspect deep links and extensions should be changed to not append VM service URI.

[kenzieschmoll]

Correct: Inspector tool window - Multiple tabs possible, one for each app Correct: Other DevTools (performance, CPU profiler, memory, etc) - Multiple tabs possible, one for each app

Incorrect: Deep links - Only one tab, Should not be associated with an app, i.e. VM service URI should not be appended Incorrect: Extensions - Only one tab, Should not be associated with an app, i.e. VM service URI should not be appended

All of these follow the multiple tabs pattern and can connect to a running app's VM service.

[helin24]

Okay, thanks for clarifying!

This is an example of what we might open for the deep links tool window once an app starts running: http://127.0.0.1:9104/deep-links?ide=Android-Studio&backgroundColor=2b2d30&theme=dark&embedMode=one&fontSize=13.0&ideFeature=toolWindow&uri=http://127.0.0.1:50501/IyPoHwyop3g=

But DevTools then opens to this error:

Is that URI param incorrect?

[kenzieschmoll]

What type of app did you run? You may be hitting this: https://github.com/flutter/devtools/issues/8228. That URI looks correct to me.

[helin24]

What type of app did you run? You may be hitting this: flutter/devtools#8228. That URI looks correct to me.

Ah yes, I am hitting that problem. I'll test this out on an Android device instead.

[helin24]

At the moment, only the inspector tool window properly supports multiple apps running at once. I would guess the prioritization of supporting multiple apps for the other tool windows is around a P3. If users mention this, we could reprioritize. The inspector tool window support for multiple apps was a user-contributed change, so potentially someone else could work on doing the same for other windows if it's important to them.

CC @jwren