flutter / flutter-intellij

Flutter Plugin for IntelliJ
https://flutter.dev/using-ide
BSD 3-Clause "New" or "Revised" License
1.98k stars 319 forks source link

Remove GA Analytics #7760

Closed jwren closed 2 days ago

jwren commented 2 weeks ago

Acknowledged and we can discuss more if you want. The counter argument though is that the Analytics API was designed with a GA-first mind set, and especially as time went on, the APIs were not called consistently, nor everywhere where we want them called from. I imagine that this PR will be used when the better analytics goes in, but now we'll have a clean history to improve code health and ultimately a better analytics story for the plugin.

kenzieschmoll commented 2 weeks ago

Ack. Do we still show the unified analytics prompt coming from the analysis server after this change? CC @bwilkerson As long as we are not removing that logic, then it's probably fine to remove all this.

jwren commented 2 weeks ago

The logic to notify the IDEs in a generic way for analytics goes through the DAS (non-flutter) protocol via the Dart plugin for IntelliJ. Relevant links:

jwren commented 1 week ago

Note: don't commit yet, the Flutter preference page has an issue with this PR, it needs to be fixed before this can land