Closed jwren closed 2 days ago
Ack. Do we still show the unified analytics prompt coming from the analysis server after this change? CC @bwilkerson As long as we are not removing that logic, then it's probably fine to remove all this.
The logic to notify the IDEs in a generic way for analytics goes through the DAS (non-flutter) protocol via the Dart plugin for IntelliJ. Relevant links:
Note: don't commit yet, the Flutter preference page has an issue with this PR, it needs to be fixed before this can land
Acknowledged and we can discuss more if you want. The counter argument though is that the Analytics API was designed with a GA-first mind set, and especially as time went on, the APIs were not called consistently, nor everywhere where we want them called from. I imagine that this PR will be used when the better analytics goes in, but now we'll have a clean history to improve code health and ultimately a better analytics story for the plugin.