search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
166.2k stars 27.5k forks source link

[impeller] impeller::DeviceBuffer::CopyHostBuffer must take fml::Mappings instead of raw pointers. #102262

Closed chinmaygarde closed 1 week ago

chinmaygarde commented 2 years ago

This will allow the OpenGL ES backend to elide a copy. These APIs were devised in the early prototyping stage before the FML dependency was taken.

chinmaygarde commented 2 years ago

This is fixed for textures in https://github.com/flutter/engine/pull/33441. The same pattern needs to be applied to device buffers as well. This is lower priority since these are usually extremely small.

jonahwilliams commented 1 week ago

Based on how we use device buffers with the new host buffer arena, changing to use fml types would be counter productive.