search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
165.09k stars 27.21k forks source link

SliverAnimatedList doc example bug #105251

Closed misterfourtytwo closed 1 year ago

misterfourtytwo commented 2 years ago

SliverAnimatedList code example has a bug, where on removal, CardWidget is built with index of an item instead of actual removed object. Though AnimatedList example doesn't contain one. image image

danagbemava-nc commented 2 years ago

Hi @misterfourtytwo, thanks for catching that.

I can confirm that there is a bug in the example.

videos | current example | fix proposed(from PR) | | -- | -- | |
misterfourtytwo commented 2 years ago

https://github.com/flutter/flutter/pull/105252 i forgot to link PR from here. I'll write some simple tests later and then will wait for approval

github-actions[bot] commented 1 year ago

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.