search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
166.37k stars 27.55k forks source link

`BottomAppBar` does not match M3 spec #118150

Closed rydmike closed 1 year ago

rydmike commented 1 year ago

BottomAppBar Gets a Drop Shadow in M3

Based on the Material 3 specification the BottomAppBar should not have a drop shadow in Material 3 design. See specification https://m3.material.io/components/bottom-app-bar/specs.

The current Flutter M3 implementation creates a default BottomAppBar in Material 3 mode that has a drop shadow.

Expected results

Expected no Material drop shadow on default BottomAppBar in Material 3 mode.

Screenshot 2023-01-08 at 2 35 04

Actual results

We get a default BottomAppBar in Material 3 mode with Material drop shadow.

BottomAppBar in M3 LIGHT (FAIL) BottomAppBar in M3 DARK (FAIL)
Screenshot 2023-01-08 at 2 28 20 Screenshot 2023-01-08 at 2 28 31

Proposal

The recently revised Material requires setting shadowColor to Colors.transparent to remove the default drop shadow in Material 3 mode. This is missing in current implementation, most likely forgotten to be added to this widget and theme when the change in Material M3 behavior was made.

The current default BottomAppBarTheme is:

class _BottomAppBarDefaultsM3 extends BottomAppBarTheme {
  const _BottomAppBarDefaultsM3(this.context)
    : super(
      elevation: 3.0,
      height: 80.0,
      shape: const AutomaticNotchedShape(RoundedRectangleBorder()),
    );

  final BuildContext context;

  @override
  Color? get color => Theme.of(context).colorScheme.surface;

  @override
  Color? get surfaceTintColor => Theme.of(context).colorScheme.surfaceTint;
}

The BottomAppBarTheme, like AppBarTheme needs to have a shadowColor property that is set to Colors.transparent and then used by underlying Material to remove the shadow.

class _BottomAppBarDefaultsM3 extends BottomAppBarTheme {
  const _BottomAppBarDefaultsM3(this.context)
    : super(
      elevation: 3.0,
      height: 80.0,
      shape: const AutomaticNotchedShape(RoundedRectangleBorder()),
    );

  final BuildContext context;

  @override
  Color? get color => Theme.of(context).colorScheme.surface;

  @override
  Color? get surfaceTintColor => Theme.of(context).colorScheme.surfaceTint;

  // Needed new property and default to match M3 spec.
  @override
  Color? get shadowColor => Colors.transparent;
}

Issue demo code

Code sample ```dart // MIT License // // Copyright (c) 2023 Mike Rydstrom // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell // copies of the Software, and to permit persons to whom the Software is // furnished to do so, subject to the following conditions: // // The above copyright notice and this permission notice shall be included in all // copies or substantial portions of the Software. // // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. import 'package:flutter/material.dart'; enum ThemeType { defaultFactory, themeDataFrom, themeDataColorSchemeSeed, } // A seed color for M3 ColorScheme. const Color seedColor = Color(0xff386a20); // Example themes ThemeData demoTheme(Brightness mode, bool useMaterial3, ThemeType type) { // Make an M3 ColorScheme.from seed final ColorScheme scheme = ColorScheme.fromSeed( brightness: mode, seedColor: seedColor, ); switch (type) { case ThemeType.defaultFactory: return ThemeData( colorScheme: scheme, useMaterial3: useMaterial3, ); case ThemeType.themeDataFrom: return ThemeData.from( colorScheme: scheme, useMaterial3: useMaterial3, ); case ThemeType.themeDataColorSchemeSeed: return ThemeData( brightness: mode, colorSchemeSeed: seedColor, useMaterial3: useMaterial3, ); } } void main() { runApp(const IssueDemoApp()); } class IssueDemoApp extends StatefulWidget { const IssueDemoApp({super.key}); @override State createState() => _IssueDemoAppState(); } class _IssueDemoAppState extends State { bool useMaterial3 = true; ThemeMode themeMode = ThemeMode.light; ThemeType themeType = ThemeType.themeDataFrom; @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, themeMode: themeMode, theme: demoTheme(Brightness.light, useMaterial3, themeType), darkTheme: demoTheme(Brightness.dark, useMaterial3, themeType), home: Scaffold( appBar: AppBar( title: const Text('BottomAppBar M3 Issue'), actions: [ IconButton( icon: useMaterial3 ? const Icon(Icons.filter_3) : const Icon(Icons.filter_2), onPressed: () { setState(() { useMaterial3 = !useMaterial3; }); }, tooltip: "Switch to Material ${useMaterial3 ? 2 : 3}", ), IconButton( icon: themeMode == ThemeMode.dark ? const Icon(Icons.wb_sunny_outlined) : const Icon(Icons.wb_sunny), onPressed: () { setState(() { if (themeMode == ThemeMode.light) { themeMode = ThemeMode.dark; } else { themeMode = ThemeMode.light; } }); }, tooltip: "Toggle brightness", ), Builder(builder: (context) { return IconButton( icon: const Icon(Icons.menu), onPressed: () { Scaffold.of(context).openEndDrawer(); }, ); }), ], ), body: HomePage( themeType: themeType, onChanged: (ThemeType value) { setState(() { themeType = value; }); }, ), drawer: const Drawer( child: Center(child: Text('Drawer')), ), endDrawer: const Drawer( child: Center(child: Text('End Drawer')), ), ), ); } } class HomePage extends StatelessWidget { const HomePage({super.key, this.themeType, this.onChanged}); final ThemeType? themeType; final ValueChanged? onChanged; @override Widget build(BuildContext context) { final ThemeData theme = Theme.of(context); final String materialType = theme.useMaterial3 ? "Material 3" : "Material 2"; return ListView( padding: const EdgeInsets.symmetric(horizontal: 16), children: [ const SizedBox(height: 8), Text( 'Issue Demo - $materialType', style: theme.textTheme.headlineSmall, ), const SizedBox(height: 16), ThemeTypeButtons( themeType: themeType, onChanged: onChanged, ), const SizedBox(height: 16), const Padding( padding: EdgeInsets.all(32.0), child: BottomAppBarShowcase(), ), const ShowColorSchemeColors(), const SizedBox(height: 16), const ShowThemeDataColors(), ], ); } } class ThemeTypeButtons extends StatelessWidget { const ThemeTypeButtons({ super.key, this.themeType, this.onChanged, }); final ThemeType? themeType; final ValueChanged? onChanged; @override Widget build(BuildContext context) { final List isSelected = [ themeType == ThemeType.defaultFactory, themeType == ThemeType.themeDataFrom, themeType == ThemeType.themeDataColorSchemeSeed, ]; return ToggleButtons( isSelected: isSelected, onPressed: onChanged == null ? null : (int newIndex) { onChanged?.call(ThemeType.values[newIndex]); }, children: const [ Padding( padding: EdgeInsets.symmetric(horizontal: 16.0), child: Text('ThemeData'), ), Padding( padding: EdgeInsets.symmetric(horizontal: 16.0), child: Text('ThemeData.from'), ), Padding( padding: EdgeInsets.symmetric(horizontal: 16.0), child: Text('ThemeData(colorSchemeSeed)'), ), ], ); } } class BottomAppBarShowcase extends StatelessWidget { const BottomAppBarShowcase({super.key}); @override Widget build(BuildContext context) { return BottomAppBar( child: Row( children: [ IconButton( tooltip: 'Open navigation menu', icon: const Icon(Icons.menu), onPressed: () {}, ), const Spacer(), IconButton( tooltip: 'Search', icon: const Icon(Icons.search), onPressed: () {}, ), IconButton( tooltip: 'Favorite', icon: const Icon(Icons.favorite), onPressed: () {}, ), ], ), ); } } /// Draw a number of boxes showing the colors of key theme color properties /// in the ColorScheme of the inherited ThemeData and its color properties. class ShowColorSchemeColors extends StatelessWidget { const ShowColorSchemeColors({super.key, this.onBackgroundColor}); /// The color of the background the color widget are being drawn on. /// /// Some of the theme colors may have semi transparent fill color. To compute /// a legible text color for the sum when it shown on a background color, we /// need to alpha merge it with background and we need the exact background /// color it is drawn on for that. If not passed in from parent, it is /// assumed to be drawn on card color, which usually is close enough. final Color? onBackgroundColor; // Return true if the color is light, meaning it needs dark text for contrast. static bool _isLight(final Color color) => ThemeData.estimateBrightnessForColor(color) == Brightness.light; // On color used when a theme color property does not have a theme onColor. static Color _onColor(final Color color, final Color bg) => _isLight(Color.alphaBlend(color, bg)) ? Colors.black : Colors.white; @override Widget build(BuildContext context) { final ThemeData theme = Theme.of(context); final ColorScheme colorScheme = theme.colorScheme; final bool useMaterial3 = theme.useMaterial3; // Grab the card border from the theme card shape ShapeBorder? border = theme.cardTheme.shape; // If we had one, copy in a border side to it. if (border is RoundedRectangleBorder) { border = border.copyWith( side: BorderSide( color: theme.dividerColor, width: 1, ), ); // If } else { // If border was null, make one matching Card default, but with border // side, if it was not null, we leave it as it was. border ??= RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(useMaterial3 ? 12 : 4)), side: BorderSide( color: theme.dividerColor, width: 1, ), ); } // Get effective background color. final Color background = onBackgroundColor ?? theme.cardTheme.color ?? theme.cardColor; // Wrap this widget branch in a custom theme where card has a border outline // if it did not have one, but retains in ambient themed border radius. return Theme( data: Theme.of(context).copyWith( cardTheme: CardTheme.of(context).copyWith( elevation: 0, shape: border, ), ), child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ Padding( padding: const EdgeInsets.symmetric(vertical: 8), child: Text( 'ColorScheme Colors', style: theme.textTheme.titleMedium, ), ), Wrap( alignment: WrapAlignment.start, crossAxisAlignment: WrapCrossAlignment.center, spacing: 6, runSpacing: 6, children: [ ColorCard( label: 'Primary', color: colorScheme.primary, textColor: colorScheme.onPrimary, ), ColorCard( label: 'on\nPrimary', color: colorScheme.onPrimary, textColor: colorScheme.primary, ), ColorCard( label: 'Primary\nContainer', color: colorScheme.primaryContainer, textColor: colorScheme.onPrimaryContainer, ), ColorCard( label: 'onPrimary\nContainer', color: colorScheme.onPrimaryContainer, textColor: colorScheme.primaryContainer, ), ColorCard( label: 'Secondary', color: colorScheme.secondary, textColor: colorScheme.onSecondary, ), ColorCard( label: 'on\nSecondary', color: colorScheme.onSecondary, textColor: colorScheme.secondary, ), ColorCard( label: 'Secondary\nContainer', color: colorScheme.secondaryContainer, textColor: colorScheme.onSecondaryContainer, ), ColorCard( label: 'on\nSecondary\nContainer', color: colorScheme.onSecondaryContainer, textColor: colorScheme.secondaryContainer, ), ColorCard( label: 'Tertiary', color: colorScheme.tertiary, textColor: colorScheme.onTertiary, ), ColorCard( label: 'on\nTertiary', color: colorScheme.onTertiary, textColor: colorScheme.tertiary, ), ColorCard( label: 'Tertiary\nContainer', color: colorScheme.tertiaryContainer, textColor: colorScheme.onTertiaryContainer, ), ColorCard( label: 'on\nTertiary\nContainer', color: colorScheme.onTertiaryContainer, textColor: colorScheme.tertiaryContainer, ), ColorCard( label: 'Error', color: colorScheme.error, textColor: colorScheme.onError, ), ColorCard( label: 'on\nError', color: colorScheme.onError, textColor: colorScheme.error, ), ColorCard( label: 'Error\nContainer', color: colorScheme.errorContainer, textColor: colorScheme.onErrorContainer, ), ColorCard( label: 'onError\nContainer', color: colorScheme.onErrorContainer, textColor: colorScheme.errorContainer, ), ColorCard( label: 'Background', color: colorScheme.background, textColor: colorScheme.onBackground, ), ColorCard( label: 'on\nBackground', color: colorScheme.onBackground, textColor: colorScheme.background, ), ColorCard( label: 'Surface', color: colorScheme.surface, textColor: colorScheme.onSurface, ), ColorCard( label: 'on\nSurface', color: colorScheme.onSurface, textColor: colorScheme.surface, ), ColorCard( label: 'Surface\nVariant', color: colorScheme.surfaceVariant, textColor: colorScheme.onSurfaceVariant, ), ColorCard( label: 'onSurface\nVariant', color: colorScheme.onSurfaceVariant, textColor: colorScheme.surfaceVariant, ), ColorCard( label: 'Outline', color: colorScheme.outline, textColor: colorScheme.background, ), ColorCard( label: 'Outline\nVariant', color: colorScheme.outlineVariant, textColor: _onColor(colorScheme.outlineVariant, background), ), ColorCard( label: 'Shadow', color: colorScheme.shadow, textColor: _onColor(colorScheme.shadow, background), ), ColorCard( label: 'Scrim', color: colorScheme.scrim, textColor: _onColor(colorScheme.scrim, background), ), ColorCard( label: 'Inverse\nSurface', color: colorScheme.inverseSurface, textColor: colorScheme.onInverseSurface, ), ColorCard( label: 'onInverse\nSurface', color: colorScheme.onInverseSurface, textColor: colorScheme.inverseSurface, ), ColorCard( label: 'Inverse\nPrimary', color: colorScheme.inversePrimary, textColor: colorScheme.primary, ), ColorCard( label: 'Surface\nTint', color: colorScheme.surfaceTint, textColor: colorScheme.onPrimary, ), ], ), ], ), ); } } /// Draw a number of boxes showing the colors of key theme color properties /// in the ColorScheme of the inherited ThemeData and some of its key color /// properties. class ShowThemeDataColors extends StatelessWidget { const ShowThemeDataColors({ super.key, this.onBackgroundColor, }); /// The color of the background the color widget are being drawn on. /// /// Some of the theme colors may have semi-transparent fill color. To compute /// a legible text color for the sum when it shown on a background color, we /// need to alpha merge it with background and we need the exact background /// color it is drawn on for that. If not passed in from parent, it is /// assumed to be drawn on card color, which usually is close enough. final Color? onBackgroundColor; // Return true if the color is light, meaning it needs dark text for contrast. static bool _isLight(final Color color) => ThemeData.estimateBrightnessForColor(color) == Brightness.light; // On color used when a theme color property does not have a theme onColor. static Color _onColor(final Color color, final Color background) => _isLight(Color.alphaBlend(color, background)) ? Colors.black : Colors.white; @override Widget build(BuildContext context) { final ThemeData theme = Theme.of(context); final bool useMaterial3 = theme.useMaterial3; // Grab the card border from the theme card shape ShapeBorder? border = theme.cardTheme.shape; // If we had one, copy in a border side to it. if (border is RoundedRectangleBorder) { border = border.copyWith( side: BorderSide( color: theme.dividerColor, width: 1, ), ); } else { // If border was null, make one matching Card default, but with border // side, if it was not null, we leave it as it was. border ??= RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(useMaterial3 ? 12 : 4)), side: BorderSide( color: theme.dividerColor, width: 1, ), ); } // Get effective background color. final Color background = onBackgroundColor ?? theme.cardTheme.color ?? theme.cardColor; // Wrap this widget branch in a custom theme where card has a border outline // if it did not have one, but retains in ambient themed border radius. return Theme( data: Theme.of(context).copyWith( cardTheme: CardTheme.of(context).copyWith( elevation: 0, shape: border, ), ), child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ Padding( padding: const EdgeInsets.only(top: 8), child: Text( 'ThemeData Colors', style: theme.textTheme.titleMedium, ), ), const SizedBox(height: 8), Wrap( spacing: 6, runSpacing: 6, crossAxisAlignment: WrapCrossAlignment.center, children: [ ColorCard( label: 'Primary\nColor', color: theme.primaryColor, textColor: _onColor(theme.primaryColor, background), ), ColorCard( label: 'Primary\nDark', color: theme.primaryColorDark, textColor: _onColor(theme.primaryColorDark, background), ), ColorCard( label: 'Primary\nLight', color: theme.primaryColorLight, textColor: _onColor(theme.primaryColorLight, background), ), ColorCard( label: 'Secondary\nHeader', color: theme.secondaryHeaderColor, textColor: _onColor(theme.secondaryHeaderColor, background), ), ColorCard( label: 'Canvas', color: theme.canvasColor, textColor: _onColor(theme.canvasColor, background), ), ColorCard( label: 'Card', color: theme.cardColor, textColor: _onColor(theme.cardColor, background), ), ColorCard( label: 'Scaffold\nBackground', color: theme.scaffoldBackgroundColor, textColor: _onColor(theme.scaffoldBackgroundColor, background), ), ColorCard( label: 'Dialog', color: theme.dialogBackgroundColor, textColor: _onColor(theme.dialogBackgroundColor, background), ), ColorCard( label: 'Indicator\nColor', color: theme.indicatorColor, textColor: _onColor(theme.indicatorColor, background), ), ColorCard( label: 'Divider\nColor', color: theme.dividerColor, textColor: _onColor(theme.dividerColor, background), ), ColorCard( label: 'Disabled\nColor', color: theme.disabledColor, textColor: _onColor(theme.disabledColor, background), ), ColorCard( label: 'Hover\nColor', color: theme.hoverColor, textColor: _onColor(theme.hoverColor, background), ), ColorCard( label: 'Focus\nColor', color: theme.focusColor, textColor: _onColor(theme.focusColor, background), ), ColorCard( label: 'Highlight\nColor', color: theme.highlightColor, textColor: _onColor(theme.highlightColor, background), ), ColorCard( label: 'Splash\nColor', color: theme.splashColor, textColor: _onColor(theme.splashColor, background), ), ColorCard( label: 'Shadow\nColor', color: theme.shadowColor, textColor: _onColor(theme.shadowColor, background), ), ColorCard( label: 'Hint\nColor', color: theme.hintColor, textColor: _onColor(theme.hintColor, background), ), ColorCard( label: 'Unselected\nWidget', color: theme.unselectedWidgetColor, textColor: _onColor(theme.unselectedWidgetColor, background), ), ], ), ], ), ); } } class ColorCard extends StatelessWidget { const ColorCard({ super.key, required this.label, required this.color, required this.textColor, this.size, }); final String label; final Color color; final Color textColor; final Size? size; @override Widget build(BuildContext context) { return SizedBox( width: 86, height: 58, child: Card( margin: EdgeInsets.zero, clipBehavior: Clip.antiAlias, color: color, child: Center( child: Text( label, style: TextStyle(color: textColor, fontSize: 11), textAlign: TextAlign.center, ), ), ), ); } } ```

Used Flutter Version

Channel master, 3.7.0-15.0.pre.16

Flutter doctor ``` [!] Flutter (Channel master, 3.7.0-15.0.pre.16, on macOS 13.0.1 22A400 darwin-arm64, locale en-US) • Flutter version 3.7.0-15.0.pre.16 on channel master at • Upstream repository https://github.com/flutter/flutter.git • Framework revision 7ddf42eae5 (20 hours ago), 2023-01-06 17:44:44 -0500 • Engine revision 33d7f8a1b3 • Dart version 3.0.0 (build 3.0.0-85.0.dev) • DevTools version 2.20.0 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0) • Android SDK at /Users/rydmike/Library/Android/sdk • Platform android-33, build-tools 33.0.0 • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 14.2) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 14C18 • CocoaPods version 1.11.3 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2021.3) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) [✓] IntelliJ IDEA Community Edition (version 2022.3.1) • IntelliJ at /Applications/IntelliJ IDEA CE.app • Flutter plugin version 71.2.6 • Dart plugin version 223.8214.16 [✓] VS Code (version 1.73.1) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.54.0 [✓] Connected device (2 available) • macOS (desktop) • macos • darwin-arm64 • macOS 13.0.1 22A400 darwin-arm64 • Chrome (web) • chrome • web-javascript • Google Chrome 108.0.5359.124 [✓] HTTP Host Availability • All required HTTP hosts are available ```
exaby73 commented 1 year ago

Triage report

Hello @rydmike. Thank you for the detailed bug report. I can reproduce this issue on Master (3.7.0-15.0.pre.16) using the code sample provided.

flutter doctor -v (Master) ``` [!] Flutter (Channel master, 3.7.0-15.0.pre.16, on macOS 13.0.1 22A400 darwin-arm64, locale en-US) • Flutter version 3.7.0-15.0.pre.16 on channel master at /Users/nabeelparkar/fvm/versions/master ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/2.18.6/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nabeelparkar/fvm/versions/master. Consider adding /Users/nabeelparkar/fvm/versions/master/bin to the front of your path. • Upstream repository https://github.com/flutter/flutter.git • Framework revision 7ddf42eae5 (2 days ago), 2023-01-06 17:44:44 -0500 • Engine revision 33d7f8a1b3 • Dart version 3.0.0 (build 3.0.0-85.0.dev) • DevTools version 2.20.0 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0) • Android SDK at /Users/nabeelparkar/Library/Android/sdk/ • Platform android-33, build-tools 33.0.0 • ANDROID_SDK_ROOT = /Users/nabeelparkar/Library/Android/sdk/ • Java binary at: /Users/nabeelparkar/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 14.2) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 14C18 • CocoaPods version 1.11.3 [✓] Chrome - develop for the web • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser [✓] Android Studio (version 2021.3) • Android Studio at /Users/nabeelparkar/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) [✓] IntelliJ IDEA Ultimate Edition (version 2022.3.1) • IntelliJ at /Users/nabeelparkar/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app • Flutter plugin version 71.3.6 • Dart plugin version 223.8214.16 [✓] IntelliJ IDEA Ultimate Edition (version 2022.3.1) • IntelliJ at /Users/nabeelparkar/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/223.8214.52/IntelliJ IDEA.app • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart [✓] VS Code (version 1.74.2) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.56.0 [✓] Connected device (3 available) • iPhone 14 Pro Max (mobile) • 6BC61E88-4DE0-4BCB-8599-DA5294269146 • ios • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator) • macOS (desktop) • macos • darwin-arm64 • macOS 13.0.1 22A400 darwin-arm64 • Chrome (web) • chrome • web-javascript • Brave Browser 108.1.46.153 [✓] HTTP Host Availability • All required HTTP hosts are available ! Doctor found issues in 1 category. ```
HansMuller commented 1 year ago

The recent fix (https://github.com/flutter/flutter/pull/119819) was reverted in https://github.com/flutter/flutter/pull/120492.

github-actions[bot] commented 1 year ago

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.