danagbemava-nc
commented
1 year ago Issue is reproducible using the code sample from the plugin example https://pub.dev/packages/in_app_purchase/example.
I see an exception thrown when I try to start a new purchase after returning from the background in the recording below. The exception is shared in the logs below.
Labeling for further investigation.
msisinni
Steps to Reproduce
in_app_purchasepackage, open your main / release AndroidManifest.xml file (by default in /android/app/src/main/)android:launchMode="singleInstance"(either by changing the existing value forlaunchModeor adding that line if you don't have it.flutter run --releasewhile a physical Android device is plugged in (Note: this also happens on versions of apps installed from the Play Store if you build the app and upload it there)*If you navigate back to your app by tapping on its icon from your list of installed apps, it'll open your Flutter app again as if the Play Store bottom sheet wasn't opened. It's almost like the Play Store bottom sheet is switched to another Activity than the one the Flutter app is running on.
Expected results: Having a Play Store bottom sheet open, navigating away from the app, and navigating back to the app not having any impact on the app while
launchMode="singleInstance"Actual results: Having a Play Store bottom sheet open, navigating away from the app, and navigating back to the app from recents appears to replace the Activity that the Flutter app is running from with a new Activity that is only running the Play Store's bottom sheet. All traces of Flutter seem to just get detached or killed without respecting the Flutter lifecycle. This can also affect the next launch of the app, because the app got killed while a purchase was pending. If the user navigates back to the app while it's in the error state and make a purchase, further attempts to make a purchase might run into an IAPError with message "BillingResponse.itemAlreadyOwned". Restoring purchases will work for subscriptions if the user subscribes in that Play Store bottom sheet only screen, but hitting restore purchases for consumables seems like it gives a new consumable every time the restore purchase button is tapped, regardless of how many were purchased. Trying to buy a consumable in that unlimited-restore-purchase state runs into the "itemAlreadyOwned" message. That might not happen in an app that verifies purchases with the app's server though - I only tested consumables with the example app.
I'm not going to attach any code samples because of how much setup an app requires to be ready for in-app purchases. If you just add that
android:launchMode="singleInstance"line to any project that is already set up for in-app purchases, you should be able to run into this issue.Logs
``` Analyzing example... No issues found! (ran in 1.6s) ``` ``` [✓] Flutter (Channel stable, 3.3.10, on macOS 12.6 21G115 darwin-arm, locale en-US) • Flutter version 3.3.10 on channel stable at /Users/matthewsisinni/Documents/flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision 135454af32 (5 weeks ago), 2022-12-15 07:36:55 -0800 • Engine revision 3316dd8728 • Dart version 2.18.6 • DevTools version 2.15.0 [✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1) • Android SDK at /Users/matthewsisinni/Library/Android/sdk • Platform android-33, build-tools 32.0.0-rc1 • ANDROID_HOME = /Users/matthewsisinni/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 14.0.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 14A400 • CocoaPods version 1.11.3 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2021.2) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840) [✓] IntelliJ IDEA Ultimate Edition (version 2022.1) • IntelliJ at /Applications/IntelliJ IDEA.app • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin version 221.5588 [✓] Connected device (3 available) • Pixel 6 Pro (mobile) • 1A271FDEE007AT • android-arm64 • Android 13 (API 33) • macOS (desktop) • macos • darwin-arm64 • macOS 12.6 21G115 darwin-arm • Chrome (web) • chrome • web-javascript • Google Chrome 109.0.5414.87 [✓] HTTP Host Availability • All required HTTP hosts are available • No issues found! ```Screenshots
This shows the example app from the in_app_purchases repo, configured for my developer account.  Opening the Play Store bottom sheet by hitting the Silver option's button  Hitting the recents button before then hitting the home button  Hitting the recents button after having gone to the home screen. Note that it stopped showing the Flutter app in the background and is instead showing my home screen behind the Play Store bottom sheet.  Dismissing the Play Store bottom sheet and hitting the recents button again. Tapping on the app does not open it back up or close recents.  Image showing what happens if you go through all those steps, but, instead of dismissing the bottom sheet, you subscribe to the app, clear the app from recents (because it can't be opened), relaunch it, and attempt to buy the same product. Note that the previous images all involved the "Silver" option. This image focuses on going through the whole process with the "Gold" one. It doesn't make a difference which one is used. thanks to @eliasteeny for figuring out it was
singleInstance