search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
166.31k stars 27.52k forks source link

[web][CanvasKit][golden] add golden test for pixelated images on web-canvasKit #118883

Open iapicca opened 1 year ago

iapicca commented 1 year ago

Description

pixelated images on web-canvasKit bug keeps coming back to stable release; please add a test/golden-test to prevent the issue to re-emerge

Expected results:

when a PR causes aforementioned bug to re-emerge a test fails and prevents it to be merged (let alone reach "stable")

Actual results:

the bug keeps coming back

Comments:

please note the comments below

this problem keeps coming back (or never really went away), maybe needs some attention! [...]

Running the gallery app locally on the latest master does not reproduce the issue, but the one hosted on gallry.flutter.dev, still does. @alanwutang11 If this issue is fixed, maybe raising another issue to include the golden files would be more suitable than clubbing it with this issue?

flutter-triage-bot[bot] commented 1 year ago

This issue is marked P1 but has had no recent status updates.

The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

adendiamond commented 5 months ago

Hi, I want to raise this issue again since there has been no progress on this since I posted this issue 18 months ago https://github.com/flutter/flutter/issues/115529 and since this issue was posted 38 months ago https://github.com/flutter/flutter/issues/79846. I find it quite peculiar that an issue of this severity has not been addressed in that amount of time, although I understand the amount of bugs that need addressing. In my apps, I'm having to blur images slightly to remove the sharp pixelated edges of my images. (Is there another workaround to use in the meantime?) Thanks.

lilran14 commented 4 months ago

Do we have any update on this issue?

iapicca commented 4 months ago

Do we have any update on this issue?

@lilran14 this issue is aimed at the creation of a test to prevent further regressions if you are experiencing a similar problem please open an issue with a runnable code sample and your flutter doctor -v output

(optional: consider "thumb up" this issue to increase visibility from the team)