No DART_DEFINE_FROM_FILES Info.plist support - Githubissues

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond

https://flutter.dev

BSD 3-Clause "New" or "Revised" License

165.67k stars 27.35k forks source link

No DART_DEFINE_FROM_FILES Info.plist support #129526

Open lukepighetti opened 1 year ago

lukepighetti commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case

We have access to DART_DEFINES entry in Info.plist, but nothing to handle --dart-define-from-file

https://github.com/flutter/flutter/blob/b2e950131786f41e57e6d517846f2e73e6149f87/packages/flutter_tools/bin/macos_assemble.sh#L109

https://github.com/flutter/flutter/blob/b2e950131786f41e57e6d517846f2e73e6149f87/packages/flutter_tools/bin/xcode_backend.dart#L368

https://github.com/flutter/flutter/blob/b2e950131786f41e57e6d517846f2e73e6149f87/packages/flutter_tools/lib/src/build_info.dart#L275

Proposal

add a DART_DEFINE_FROM_FILES entry in Info.plist that takes a list of files (if --dart-define-from-file can be used multiple times)

christopherfujino commented 1 year ago

@lukepighetti thanks for tracing out all the places in the source.