flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
163.13k stars 26.84k forks source link

[Windows] Move `FlutterWindow` mocking to `WindowsProcTable` #140626

Open loic-sharma opened 6 months ago

loic-sharma commented 6 months ago

Background

The FlutterWindow is one of the fundamental types of the Windows embedder. It listens to the Windows event loop, processes keyboard events, handles IME composition, accessibility, and more.

On top of all of this, it is also used to mock win32 APIs:

These are debatable candidates:

Solution

The WindowsProcTable was introduced to allow mocking win32 APIs. FlutterWindow methods that exist for mocking purposes should be moved to the WindowsProcTable.

flutter-triage-bot[bot] commented 4 weeks ago

The triaged-desktop label is irrelevant if there is no team-desktop label or fyi-desktop label.