darshankawar
commented
7 months ago @waliseddiqi
Most probably you are hitting https://github.com/flutter/flutter/issues/107982 that you can check and confirm.
Also, this could be occuring due to the fact that you are passing debugLogDiagnostics: true. Can you try by passing it as false and check if log is duplicated still ?
Moreover, check this and other underlying comments from the linked issue to see if they help to get expected result or not.
Please check above using latest go_router version.
waliseddiqi
github-actions[bot]
Steps to reproduce
by using the latest go router version with latest logging package version can be reproduced as below
logging package : https://pub.dev/packages/logging
debugLogDiagnostics: truein GoRouterAlso with version
go_router: ^10.2.0and below the logs seems like working fine and shows withdebugLogDiagnostics: falseto falseflutter:
3.16.5go_router:13.1.0logginer:1.2.0Expected results
Expected logs
Actual results
Duplicated logs after setting
debugLogDiagnostics: trueCode sample
Code sample
``` import 'dart:async'; import 'package:equatable/equatable.dart'; import 'package:logging/logging.dart'; import 'plain_log_writer.dart'; class LogConfig { static StreamSubscription? loggerSubscription; static void init({required Level logLevel}) { final PlainStdoutLogWriter logWriter = PlainStdoutLogWriter(); Logger.root.level = logLevel; loggerSubscription?.cancel(); loggerSubscription = Logger.root.onRecord.listen((LogRecord record) { if (record.error is Error) { logWriter.logError(record, record.error as Error); } else if (record.error is Exception) { logWriter.logException(record, record.error as Exception); } else if (record.stackTrace != null) { logWriter.logStacktrace(record, record.stackTrace!); } else { logWriter.logRecord(record); } }); // use generated (by equatable) toString methods for logging out objects EquatableConfig.stringify = true; Logger.root.info('Started logging on level ${Logger.root.level} with $logWriter'); } } ``` and ``` import 'package:flutter/foundation.dart'; import 'package:logging/logging.dart'; class PlainStdoutLogWriter { void logError(LogRecord record, Error error) { _printLog(record, ': $error\n${error.stackTrace}'); } void logException(LogRecord record, Exception exception) { _printLog(record, ': $exception\n${record.stackTrace ?? ""}'); } void logStacktrace(LogRecord record, StackTrace stackTrace) { _printLog(record, ': ${record.error}\n${record.stackTrace ?? "null stackTrace"}'); } void logRecord(LogRecord record) { _printLog(record); } void _printLog(LogRecord record, [String extraMessage = '']) { // don't log if turned off if (record.level < Level.OFF) { // Here it is ok to print(), we are using the logger until here. // ignore: avoid_print debugPrint('${record.time} ${record.level.name} - ${record.loggerName}: ${record.message}$extraMessage'); } } } ``` also by setting the log level to any not above `INFO` ` LogConfig.init(logLevel: Level.FINE);`Screenshots or Video
Also duplicated logs shows as yellow color in VScode
Flutter Doctor output
[!] Flutter (Channel [user-branch], 3.16.5, on macOS 14.3 23D56 darwin-arm64, locale en-DE) ! Flutter version 3.16.5 on channel [user-branch] at /Users/**/Development/flutter Currently on an unknown channel. Run
flutter channelto switch to an official channel. If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install. ! Upstream repository unknown source is not a standard remote. Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error. • Framework revision 78666c8dc5 (9 weeks ago), 2023-12-19 16:14:14 -0800 • Engine revision 3f3e560236 • Dart version 3.2.3 • DevTools version 2.28.4 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.[!] Android toolchain - develop for Android devices (Android SDK version 33.0.1) • Android SDK at /Users/**/Library/Android/sdk ✗ cmdline-tools component is missing Run
path/to/sdkmanager --install "cmdline-tools;latest"See https://developer.android.com/studio/command-line for more details. ✗ Android license status unknown. Runflutter doctor --android-licensesto accept the SDK licenses. See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.[!] Xcode - develop for iOS and macOS (Xcode 15.2) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 15C500b ✗ Unable to get list of installed Simulator runtimes. • CocoaPods version 1.14.3
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome) ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Android Studio (version 2023.1) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
[✓] VS Code (version 1.79.2) • VS Code at /Users/**/Downloads/Visual Studio Code.app/Contents • Flutter extension version 3.82.0
[✓] Connected device (3 available) • 2201123G (mobile) • 7b5a8447 • android-arm64 • Android 13 (API 33) • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64 • Android 13 (API 33) (emulator) • macOS (desktop) • macos • darwin-arm64 • macOS 14.3 23D56 darwin-arm64
[✓] Network resources • All expected network resources are available.
! Doctor found issues in 4 categories.